Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Modify Outputs #52

Merged
merged 6 commits into from
Aug 26, 2024
Merged

🔨 Modify Outputs #52

merged 6 commits into from
Aug 26, 2024

Conversation

migbro
Copy link
Collaborator

@migbro migbro commented Aug 26, 2024

Description

RDS files are generally undesirable as they are sensitive to R versions and can be a bit bloated. Critical info has been broken out into TSV and h5 format files:

  • QC metrics no longer buries in seurat object pulling them out into a simple TSV file
  • Typical counts matrix store in h5 format instead, which can easily be converted into Cell Ranger style directories using DropletUtils and read in directly using popular Single Cell analysis software suite Seurat using Read10X_h5
  • Updated docs to reflect these changes and prep for prod release

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • QC only
  • Within workflow - note, minor difference that table header names are different, before change implemented

Test Configuration:

  • Environment:
  • Test files:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have committed any related changes to the PR

📝 rename some output vars for clarity
📝 update docs to reflect changes and fix typos
📝 update docs and fix typos
🔨 add mem input for QC
@migbro migbro added documentation Regarding developer or user documentation feature New functionality bix-dev labels Aug 26, 2024
@migbro migbro self-assigned this Aug 26, 2024
Copy link
Contributor

@dmiller15 dmiller15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with the salmon-rnaseq submodule? Should that be here?

@migbro migbro merged commit a0ef5c0 into master Aug 26, 2024
1 check failed
@migbro migbro deleted the feature/mb-mod-outputs branch August 26, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bix-dev documentation Regarding developer or user documentation feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants