Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 update tumor only workflow #16

Merged
merged 7 commits into from
Jun 6, 2024
Merged

🚧 update tumor only workflow #16

merged 7 commits into from
Jun 6, 2024

Conversation

dmiller15
Copy link
Contributor

@dmiller15 dmiller15 commented May 22, 2024

Description

Part of https://d3b.atlassian.net/browse/BIXU-2125
Part of https://d3b.atlassian.net/browse/BIXU-3672

Filtration Updates

  • Updated README with new recommended gatk_filter_name and gatk_filter_expression values
  • Added new default to filtermutectcalls_extra_args to filter calls with AF < 0.01

Workflow Optimization

  • ControlFREEC pileup creation now handled by a GNU parallel samtools implementation; no longer performing pileup on ALT contigs
  • Interval creation and handling now matches what we have in the somatic workflow; user provides calling_regions, blacklist_regions, and cnv_blacklist_regions which are then processed by prepare_regions.cwl
  • Added interval manipulation tools: awk_chrlen_builder.cwl, gatk_bedtointervallist.cwl, gatk_intervallisttobed.cwl, and gatk_intervallisttools.cwl
  • Added switches to enable/disable all subworkflows of the tumor only workflow
  • Move AnnotSV inside Manta subworkflow
  • samtools calmd now only runs when the input is CRAM or if user specifies run_calmd_bam

Quality of Life

  • Added default of [2,3,4] to cfree_ploidy
  • Reference input simplified to a single input with secondaryFile indexes rather than separate inputs for FASTA, FAI, and DICT
  • Added suggestedFiles for indexed_reference_fasta, gem_mappability_file, panel_of_normals, blacklist_regions, and cnv_blacklist_regions

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

  • Environment:
  • Test files:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have committed any related changes to the PR

@dmiller15 dmiller15 self-assigned this May 29, 2024
@dmiller15 dmiller15 added documentation Regarding developer or user documentation feature New functionality bix-dev labels May 29, 2024
@dmiller15 dmiller15 marked this pull request as ready for review June 3, 2024 17:38
Base automatically changed from dm-filtration-updates to main June 3, 2024 20:33
dmiller15 and others added 5 commits June 3, 2024 20:34
🔧 update readme and pubapp format

update docker table

🔧 update readme and pubapp format

update docker table

📚 update pubapp styling
📚 update filetypes

🔧 add suggested blacklists/PON
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Miguel Brown <miguel.a.brown@gmail.com>
@migbro migbro self-requested a review June 6, 2024 15:08
Copy link
Collaborator

@migbro migbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Could look into replacing verbatim tool copies with raw git links, but at this point, probably not worth fawning over. Do we want to throw in the release version now, or later?

tools/samtools_mpileup.cwl Show resolved Hide resolved
workflows/kfdrc_tumor_only_dna_wf.cwl Show resolved Hide resolved
@dmiller15
Copy link
Contributor Author

Could look into replacing verbatim tool copies with raw git links, but at this point, probably not worth fawning over.

Yeah probably worth looking into during the strategic week next month. Perhaps we should make a ticket @migbro

Do we want to throw in the release version now, or later?

Later. I think there's a couple more things that we'll need to go over like workflow/output naming.

@dmiller15 dmiller15 merged commit c77bb70 into main Jun 6, 2024
1 check passed
@dmiller15 dmiller15 deleted the dm-post-bench-wf branch June 6, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bix-dev documentation Regarding developer or user documentation feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants