Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👷 Run CI (lint, tests) on Github Workflows #23

Merged
merged 8 commits into from
Jun 22, 2023
Merged

👷 Run CI (lint, tests) on Github Workflows #23

merged 8 commits into from
Jun 22, 2023

Conversation

znatty22
Copy link
Member

@znatty22 znatty22 commented Jun 22, 2023 •
edited
Loading

Motivation

Most of our repos run CI (linting, tests, etc) on Github workflows. We should standardize this repo and also run CI on Github instead of CircleCI

Approach

  • Replace CircleCI CI workflow with a Github workflow
  • Add a docker-compose file with a setup script to this repo for local dev
  • Use docker-compose in CI to run tests against Dataservice

@znatty22 znatty22 self-assigned this Jun 22, 2023
@znatty22 znatty22 marked this pull request as ready for review June 22, 2023 18:13
@znatty22 znatty22 merged commit e7e4b2a into master Jun 22, 2023
@znatty22 znatty22 deleted the ci-on-gh branch June 22, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@znatty22 znatty22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@znatty22