-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DROOLS-7605] WebSphere kie-server-tests fails #3021
Conversation
@@ -1253,6 +1253,7 @@ | |||
<home>${websphere.home}</home> | |||
<timeout>240000</timeout> | |||
<systemProperties> | |||
<org.kie.server.id>test-kie-server</org.kie.server.id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very sure if this is the right way to fix. We want to use a test utility class to set the serverId
?
Interestingly, this issue doesn't happen with other containers (wildfly, tomcat, weblogic), so probably it has something to do with when serverId
should be set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess websphere doesn't execute ServletContextListener on deployment (so Bootstrap mechanism to provide an arbitrary name doesn't work here), but as this parameter is mandatory, it's a good fix.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
jenkins do fdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Tested and worked properly, awesome work @tkobayas !
@@ -1253,6 +1253,7 @@ | |||
<home>${websphere.home}</home> | |||
<timeout>240000</timeout> | |||
<systemProperties> | |||
<org.kie.server.id>test-kie-server</org.kie.server.id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess websphere doesn't execute ServletContextListener on deployment (so Bootstrap mechanism to provide an arbitrary name doesn't work here), but as this parameter is mandatory, it's a good fix.
@tkobayas please add backport labels for 7.67.x and blue |
jenkins do fdb |
GHA Java 11: Flaky
|
@mareknovotny Could you please merge this PR? Thanks! |
JIRA:
https://issues.redhat.com/browse/DROOLS-7605
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
a pull request please add comment: Jenkins retest this
a full downstream build please add comment: Jenkins run fdb
a compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.