[FIX] custom fix when xml adapter has names #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins retest this please |
porcelli
reviewed
Jul 18, 2024
|
|
||
| XmlElements elements = findAnnotation(XmlElements.class, a, false, false, false); | ||
| if (elements != null) { | ||
| for (XmlElement elem : elements.value()) { |
There was a problem hiding this comment.
can't we check jsonHandleXmlAnyElementsNames before the loop, so we can avoid unnecessary processing (I know that over time JIT will do the job... but still)
There was a problem hiding this comment.
it won't give the same outcome.
| @@ -1160,4 +1171,8 @@ public void setClassLoader(ClassLoader classLoader) { | |||
| public ClassLoader getClassLoader() { | |||
| return classLoader; | |||
| } | |||
|
|
|||
| public void setXmlAnyElementsNames(boolean jsonHandleXmlAnyElementsNames) { | |||
There was a problem hiding this comment.
is this method used only for testing purposes? if yes... maybe there's a better way to do so.... I personally like Anonymous classes for hack the tested class... but I also understand that it might not be the most popular design choice.
martinweiler
approved these changes
Jul 29, 2024
elguardian
added
backport-7.67.x
elguardian
added a commit
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance problem was related to the polymorphic feature of jackson. it computes the subtypes of a given types.
Before the patch we were saying that all classes contained in the kjar/project where subtypes of every class causing a huge impact in performance
That performance problem was causing another problem, it was overwriting the proper names for types
Every class when you are serializing you have the full qualified name and the name used for serialized and deserialized
So before the patch we were overwriting that information making this feature not working properly
Now because the subtypes are being computed properly we are not overwriting the names therefore now the name is being taken from the annotation like it should be