Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change version of tomli-w #75

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

turboBasic
Copy link

🤔 What's changed?

Bump version of tomli-w

⚡️ What's your motivation?

Fixes following error:

An unexpected error has occurred: CalledProcessError: command: ('$HOME/.cache/pre-commit/repo6a1zzrzt/py_env-python3.12/bin/python', '-mpip', 'install', '.')
return code: 1
...
stderr:
    ERROR: Some build dependencies for file:///$HOME/.cache/pre-commit/repo6a1zzrzt conflict with the backend dependencies: tomli-w==1.1.0 is incompatible with tomli-w==1.0.0.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:


This text was originally generated from a template, then edited by hand. You can modify the template here.

@turboBasic turboBasic marked this pull request as ready for review October 22, 2024 12:00
@louisbzk
Copy link

louisbzk commented Nov 25, 2024

Hi, I had the same problem with the tomli-w dependency. I solved it using tomli-w>=1.0.0 and skipping the pyprojectsort pre-commit hook (because the project references itself as a hook). Not sure how it can be done in a clean way though.

@turboBasic
Copy link
Author

It looks like it fixes #77

Copy link
Owner

@kieran-ryan kieran-ryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turboBasic, thanks so much for the contribution! Missed notification. Would it be possible to provide me with access to contribute on your fork? Wanted to cherry-pick in change from @louisbzk into your branch - to ensure their contribution is included - though being from the main branch on the fork prevents.

Though otherwise you may be able to apply same.

git remote add fork https://github.com/louisbzk/pyprojectsort
git fetch fork
git cherry-pick fork/main

Then accept and push the incoming changes.

git cherry-pick --continue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress 🏃‍♂️
Development

Successfully merging this pull request may close these issues.

3 participants