Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/alex work1 - submitting programming test/exercise. #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/alex work1 - submitting programming test/exercise. #96

wants to merge 2 commits into from

Conversation

AlexGordonGBS
Copy link

  • refactored code
  • fixed issues
  • created 22 unit tests
  • added Constants.java class
  • create javadoc

@AlexGordonGBS
Initial setup:
b82e3da 
(1) changed to Java 1.8
(2) some additions for .gitignore.
@AlexGordonGBS
What was done:
7c76c7d 
(1) refactored all application classes
(2) cleaned up all the code
(3) externalized all constants inot a separate class
(4) create 22 JUnit test cases. 
(5) removed all existing test cases - they all were NOT systematic
(6) converted the application to the Java 1.8 level
(7) NOTE: the interest calculation task is understood as per this ONE
day ONLY. That is why I am using "daily rate" values in calculations.

Further TODO list:
	- convert all dollar amount from double to BigDecimal
	- create more unit tests
	- design and implement nightly batch process - to calculate daily
interest, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AlexGordonGBS