Fix sensor registration at Sensors::CO2scd30Init() and Sensors::CO2scd4xInit() #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not multiply scd30.getTemperatureOffset() by 100 (it´s already in hundreths of a degree C) to avoid setting temperature offset on each sensor init. Do sensorRegister(SENSORS::SSCD30) prior to seeting offsets.
7 tasks
melkati
changed the title
hpsaturn
requested changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I moved the sensor registration up in Sensors::CO2scd30Init() and Sensors::CO2scd4xInit() to fix (2).
I don't see any side effects. Tested with both sensors in CO2 Gadget and looks like it's working fine.
In Sensors::CO2scd30Init() I also changed In Sensors::CO2scd30Init() to multiply toffset * 100 to convert into hundredths of a degree C to comply with Sensirion's API.
Maybe we should do the same for Sensors::sen5xInit() but I don't have one to test.
Related Issues
This is one partial fix for issue #203
Tests
I added the following tests:
I don't see any side effects. Tested with both sensors in CO2 Gadget and looks like it's working fine.