Skip to content

Commit

Permalink
# This is a combination of 2 commits.
Browse files Browse the repository at this point in the history
# This is the 1st commit message:

# This is a combination of 2 commits.
# This is the 1st commit message:

# This is a combination of 3 commits.
# This is the 1st commit message:

# This is a combination of 9 commits.
# This is the 1st commit message:

# This is a combination of 15 commits.
# This is the 1st commit message:

# This is a combination of 49 commits.
# This is the 1st commit message:

# This is a combination of 2 commits.
# This is the 1st commit message:

# This is a combination of 25 commits.
# This is the 1st commit message:

flake8

# This is the commit message mozilla-lockwise#2:

Refresh OAuth Access Tokens (mozilla-lockwise#547)


# This is the commit message mozilla-lockwise#3:

Styling adjustments for the account dropdown. (mozilla-lockwise#549)


# This is the commit message mozilla-lockwise#4:

Update Version and Release Notes to 0.1.7-alpha (mozilla-lockwise#558)


# This is the commit message mozilla-lockwise#5:

chore(package): update eslint-plugin-no-unsanitized to version 3.0.0 (mozilla-lockwise#537)


# This is the commit message mozilla-lockwise#6:

chore(package): update mocha to version 5.0.1 (mozilla-lockwise#544)


# This is the commit message mozilla-lockwise#7:

chore(package): update stylelint to version 9.1.1 (mozilla-lockwise#566)


# This is the commit message mozilla-lockwise#8:

chore(package): update stylelint-config-recommended to version 2.1.0 (mozilla-lockwise#551)


# This is the commit message mozilla-lockwise#9:

Add Support For Telemetry Scalars; Update Metrics.md (mozilla-lockwise#552)


# This is the commit message mozilla-lockwise#10:

Provide documentation about how to post PRs (mozilla-lockwise#507)



# This is the commit message mozilla-lockwise#11:

Ensure FxA account is stored always (mozilla-lockwise#570)


# This is the commit message mozilla-lockwise#12:

Update Version and Release Notes to 0.1.7-alpha1 (mozilla-lockwise#571)


# This is the commit message mozilla-lockwise#13:

Updated text color of entry list empty state for better contrast (mozilla-lockwise#560)


# This is the commit message mozilla-lockwise#14:

Add config file for pyup.io to update weekly (mozilla-lockwise#586)

* create pyup.io config file

* update all dependencies, not just security

* remove extra whitespace

# This is the commit message mozilla-lockwise#15:

Update flake8-isort from 2.2.2 to 2.4 (mozilla-lockwise#587)


# This is the commit message mozilla-lockwise#16:

Update pytest from 3.3.1 to 3.4.1 (mozilla-lockwise#589)


# This is the commit message mozilla-lockwise#17:

Update pytest-selenium from 1.11.3 to 1.11.4 (mozilla-lockwise#590)


# This is the commit message mozilla-lockwise#18:

Update pypom from 1.2.0 to 1.3.0 (mozilla-lockwise#594)


# This is the commit message mozilla-lockwise#19:

Update selenium from 3.8.0 to 3.9.0 (mozilla-lockwise#592)


# This is the commit message mozilla-lockwise#20:

Update pytest-xdist from 1.20.1 to 1.22.2 (mozilla-lockwise#591)


# This is the commit message mozilla-lockwise#21:

Update flake8-docstrings from 1.1.0 to 1.3.0 (mozilla-lockwise#588)


# This is the commit message mozilla-lockwise#22:

More account dropdown style updates (mozilla-lockwise#597)

* Styling updates based off Jim's code review of mozilla-lockwise#549

-Updated pseudo-elements to have two colons instead of one
-Moved toolbar margin update to be specific to navigation bar
-Removed arrowhead down icon that is no longer in use
-Updated dropdown hover, focus and active states after reviewing how Firefox browser handles similar items

* Updating toolbar to use px instead of ch to be consistent.

# This is the commit message mozilla-lockwise#23:

Include whitespace in item fields so new lines are output (mozilla-lockwise#596)

* Include whitespace in item fields so new lines are output

* move white-space to all input text fields

# This is the commit message mozilla-lockwise#24:

Automatically focus the filter input when the page loads; resolves mozilla-lockwise#573

# This is the commit message mozilla-lockwise#25:

Styling updates around entry list items (mozilla-lockwise#553)

* Styling updates around entry list items

-Active and focus states
-Increased padding to match mocks
-New chevron icon
-Updated aside background color
-Moved border between search and entries in order to apply active border color to top entry item
-Small copy change to empty state

* Changes based off PR feedback

-Removed arrowhead right icon that is no longer used
-Removed some styling around border between filter and list items until we get the filter updated.

* Add custom "no username" instruction text when adding entry

* Remove string interpolation and use better const name

* Ran cheveron-right through svgo, sizing was also updated.

# This is the commit message mozilla-lockwise#2:

0.1.7-alpha1 (mozilla-lockwise#574)


# This is the commit message mozilla-lockwise#2:

Updating styling of 0 entries (home) page to reflect intended typography and spacing (mozilla-lockwise#607)

- Into image shadow to Shadow 10
- Updated image border
- Defined line height for intro paragraphs
# This is the commit message mozilla-lockwise#3:

Create a <PanelFooterButton/> and update the styles for the unlock do… (mozilla-lockwise#601)

* Create a <PanelFooterButton/> and update the styles for the unlock doorhanger; resolves mozilla-lockwise#482

* latest Nessie with darker waves

# This is the commit message mozilla-lockwise#4:

Update selenium from 3.9.0 to 3.10.0
# This is the commit message mozilla-lockwise#5:

chore(package): update documentation to version 6.0.0
# This is the commit message mozilla-lockwise#6:

Require python 3.6 in deploy stage so pip can install tornado

# This is the commit message mozilla-lockwise#7:

Create/Edit Entry Details Styling Adjustments (mozilla-lockwise#567)

* Styling adjustments for entry details

-Added show/hide icons for password
-Reordered fields to match new designs
-Removed monospace class from username field
-Fixed sizing/spacing to match designs
-Updated to use box-sizing: border box, and fixed issues this caused in other areas
-Updated placeholder copy and labels to match design changes
-Added min-width to buttons

* Adding min-width to normal button style and larger min-width for primary buttons

* Styling for dialog box and adding new critical/red button style

* Changes based on PR review

-ran svgo on show icon to optimize
-created new notes class in entry details for styling
-removed box sizing and associated style changes
-moved password styles to input.css
-Removed show/hide button text and keys
-Changed critical theme to danger theme
-Reverted dialog to use primary button by default

* Re-localize the show/hide password input buttons

* Fix input tests to also check for first "input" class

* Better RegEx for munged password input class tests

* Fixing missed styles from box-sizing removal that needed updated

* Provide the option of using "danger" buttons in dialog boxes

These are currently used in two places:
* Deleting items
* Resetting the datastore

* restore indentation

* Fixes based on PR changes requested

-Ran show icon through svgo
-Moved input max-width for entry creation/edition fields to item-fields.css
-Created new "wide" button sub-theme for instances to include min-width property
-Added size theme to save/edit button on entry details

* Adding .input class to item fields for styling and removing unnecessary selector

# This is the commit message mozilla-lockwise#8:

Improvements to search bar styling in full manage mode (mozilla-lockwise#562)

* Styling adjustments for entry list filter.

-Added search icon
-Updated padding/colors
-Included clear icon but needs implemented
-Removed "entries" from placeholder copy

* Styling updates for entries list filter in aside

-Fixed padding/sizing to match design
-Added search icon
-Replaced text link with 'clear icon'
-Updated placeholder copy to 'search lockbox'

* Changes after review with Ryan

-Darkening placeholder text
-Updated border radius on inputs
-Reverting search to use regular weight

* Moving location of styles for filter/search in order to cover both doorhanger and full page view

* Adding MPL-2.0 license to item-filter file and new line on app.css

* Updates based on PR feedback

-Added new line at end of SVG files
-Removed item-filter.css and moved styles to input.css file
-Wrapped filter in <toolbar> element and applied padding there
-Added title attribute to clear button

* Removing "clear" text from filter button

* Update input test regex to include first input filter class

* Restore localization of "Clear" text on search

* Better RegEx for munged input class tests

* Removed some unnecessary styles left behind and updated padding for consistency.

* Ran clear and search svgs through svgo

* Restore filter styles lost in master branch merge 28e31d5

# This is the commit message mozilla-lockwise#9:

Make sure options_ui is fully displayed on about:addons (mozilla-lockwise#603)

* Make sure options_ui is fully displayed on about:addons

* flex-direction is actually not necessary, not sure why i ended up with it

* add margin so button focus state fits and text aligns with items above

* add min-height to give the warning dialog more room to breathe

# This is the commit message mozilla-lockwise#10:

added accessibility test plan to docs

# This is the commit message mozilla-lockwise#11:

Attempt to speed up branch and PR builds with Travis CI caching (mozilla-lockwise#604)

* Speed up branch and PR builds with Travis CI caching
* add pip cache

# This is the commit message mozilla-lockwise#12:

writing jenkins config

# This is the commit message mozilla-lockwise#13:

fixed typo

# This is the commit message mozilla-lockwise#14:

edited jenkins config

# This is the commit message mozilla-lockwise#15:

edited jenkins config

# This is the commit message mozilla-lockwise#16:

edited jenkins config

# This is the commit message mozilla-lockwise#17:

edited jenkins config

# This is the commit message mozilla-lockwise#18:

edited jenkins config

# This is the commit message mozilla-lockwise#19:

edited jenkins config

# This is the commit message mozilla-lockwise#20:

edited jenkins config

# This is the commit message mozilla-lockwise#21:

edited jenkins config

# This is the commit message mozilla-lockwise#22:

edited jenkins config

# This is the commit message mozilla-lockwise#23:

edited jenkins config

# This is the commit message mozilla-lockwise#24:

edited jenkins config

# This is the commit message mozilla-lockwise#25:

added jenkins build script

# This is the commit message mozilla-lockwise#26:

edited jenkins config

# This is the commit message mozilla-lockwise#27:

edited jenkins config

# This is the commit message mozilla-lockwise#28:

edited jenkins config

# This is the commit message mozilla-lockwise#29:

edited jenkins config

# This is the commit message mozilla-lockwise#30:

edited jenkins config

# This is the commit message mozilla-lockwise#31:

edited jenkins config

# This is the commit message mozilla-lockwise#32:

edited jenkins config

# This is the commit message mozilla-lockwise#33:

edited jenkins config

# This is the commit message mozilla-lockwise#34:

edited jenkins config

# This is the commit message mozilla-lockwise#35:

including a11y tests

# This is the commit message mozilla-lockwise#36:

flake8

# This is the commit message mozilla-lockwise#37:

flake8

# This is the commit message mozilla-lockwise#38:

removed pypom from test reqs

# This is the commit message mozilla-lockwise#39:

edited jenkins config

# This is the commit message mozilla-lockwise#40:

edited jenkins config

# This is the commit message mozilla-lockwise#41:

edited jenkins config

# This is the commit message mozilla-lockwise#42:

edited jenkins config

# This is the commit message mozilla-lockwise#43:

edited jenkins config

# This is the commit message mozilla-lockwise#44:

Styling adjustment to align entry detail buttons during edit and view mode change (mozilla-lockwise#608)


# This is the commit message mozilla-lockwise#45:

Fix <ItemFilter/> to actually update its state from Redux

# This is the commit message mozilla-lockwise#46:

Fix importing of chai-enzyme in <ButtonStack/> test

# This is the commit message mozilla-lockwise#47:

Automatically select the filter input's text on load (if there is any)

# This is the commit message mozilla-lockwise#48:

Pre-fill the URL of the current tab into the doorhanger's filter

# This is the commit message mozilla-lockwise#49:

Prepare 0.1.8 release (mozilla-lockwise#612)

* bump version numbers to 0.1.8-alpha

* draft release notes based on current progress

and fixed release note headings in previous release

* recent additions for release notes

* last items included in this release

* remove depdencies updates from release notes

# This is the commit message mozilla-lockwise#2:

Fix the color of the horizontal line in the item details of the manager

# This is the commit message mozilla-lockwise#3:

edited jenkins config

# This is the commit message mozilla-lockwise#4:

edited jenkins config

# This is the commit message mozilla-lockwise#5:

edited jenkins config

# This is the commit message mozilla-lockwise#6:

edited jenkins config

# This is the commit message mozilla-lockwise#7:

edited jenkins config

# This is the commit message mozilla-lockwise#8:

edited jenkins config

# This is the commit message mozilla-lockwise#9:

edited jenkins config

# This is the commit message mozilla-lockwise#10:

edited jenkins config

# This is the commit message mozilla-lockwise#11:

edited jenkins config

# This is the commit message mozilla-lockwise#12:

edited jenkins config

# This is the commit message mozilla-lockwise#13:

edited jenkins config

# This is the commit message mozilla-lockwise#14:

Move python runtime for deploy stage out of 'on' requirement

So the pages actually build using python 3.6 instead of just checking to make sure its in the 3.6 runtime

# This is the commit message mozilla-lockwise#15:

Downgrade Travis deploy script to fix pages deploy
See travis-ci/travis-ci#9312

# This is the commit message mozilla-lockwise#2:

Improve implementation of <Stack/> (formerly <ButtonStack/>)

Unfortunately, to have behavior like <xul:deck>, the only way I can figure out
is just to use the XUL box model. :(

# This is the commit message mozilla-lockwise#3:

Allow greater customization of <CopyToClipboardButton/>

# This is the commit message mozilla-lockwise#4:

Provide visuals for the quick-copy buttons in the doorhanger list view

# This is the commit message mozilla-lockwise#5:

Add support for copying the username and password from the quick-copy buttons

# This is the commit message mozilla-lockwise#6:

Add telemetry for the quick-copy buttons

# This is the commit message mozilla-lockwise#7:

Address styling concerns

# This is the commit message mozilla-lockwise#8:

Add tests for quick-copy behavior

# This is the commit message mozilla-lockwise#9:

Address mozilla-lockwise#570 Post-Merge Code Review Comments (mozilla-lockwise#647)


# This is the commit message mozilla-lockwise#2:

changes to metrics

# This is the commit message mozilla-lockwise#3:

Update stylelint to the latest version 🚀 (mozilla-lockwise#658)

* chore(package): update stylelint to version 9.1.2

* chore(package): update stylelint to version 9.1.3

# This is the commit message mozilla-lockwise#2:

Update flake8-isort from 2.4 to 2.5 (mozilla-lockwise#671)


# This is the commit message mozilla-lockwise#2:

Docs are wrong becuase sync is not currently supported

fixes mozilla-lockwise#670
  • Loading branch information
kimberlythegeek committed Mar 21, 2018
1 parent c87cb32 commit 6da39d8
Show file tree
Hide file tree
Showing 106 changed files with 2,492 additions and 1,232 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ __pycache__
.tox
*.log
*.pyc
.pytest_cache
/results/
3 changes: 3 additions & 0 deletions .pyup.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# see https://pyup.io/docs/configuration/ for all available options

schedule: every week
8 changes: 8 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ _aliases:
language: node_js
node_js: stable

cache:
directories:
- node_modules
cache: pip

sudo: required
jobs:
include:
Expand Down Expand Up @@ -47,8 +52,11 @@ jobs:
- stage: deploy
if: branch = master
<<: *node
python: '3.6'
script: skip
deploy:
edge:
branch: v1.8.47
provider: pages
on:
branch: master
Expand Down
56 changes: 56 additions & 0 deletions Jenkinsfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
#!/usr/bin/env groovy

/** Desired capabilities */
def capabilities = [
browserName: 'Firefox',
version: '58.0',
platform: 'Windows 10'
]

pipeline {
agent any
stages {
stage('Checkout') {
steps {
deleteDir()
checkout scm
stash 'workspace'
}
}
stage('Lint') {
steps {
deleteDir()
unstash 'workspace'
ansiColor('xterm') {
sh """
pip install -r requirements/flake8.txt
python -m flake8
"""
}
}
}
stage('Test') {
environment {
SAUCELABS = credentials('SAUCELABS')
}
steps {
unstash 'workspace'
ansiColor('xterm') {
sh """
npm install
git init
npm run package
mkdir results
tox -e sauce
"""
}
}
post {
always {
stash includes: 'results/*', name: 'results'
archiveArtifacts 'results/*'
}
}
}
}
}
2 changes: 2 additions & 0 deletions docs/.dir-locals.el
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
((markdown-mode
(mode . visual-line)))
48 changes: 48 additions & 0 deletions docs/accessibility-test-plan.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
# Manual Test Plan

## Keyboard Navigation
_< 3 hours_

Navigate the web content using only the keyboard
- Tab Order:`TAB`, as well as `SHIFT + TAB`, follows a logical and intuitive order.
- All controls, links, buttons, etc., get focused.
- Focus should be visibly apparent.
- When a modal or pop up window opens, focus shifts to the pop up.
- Focus and tab order is constrained within the modal.
- Modal can be exited via keyboard.
- When a pop up window is closed, focus returns to a logical point.
- Ensure that all content that is visually hidden is also hidden from the keyboard and/or a screen reader. _Except content specifically for screen reader users._
- Firefox toolbar icon can be accessed by keyboard and screen reader users.

## Page Structure
_3 hours_
- Links and buttons have text that give context.
- All images contain alt text to describe the purpose or content of the image to a non-sighted user.
- A logical hierarchy of header tags has been used.
- [ARIA landmark roles](https://accessibility.oit.ncsu.edu/it-accessibility-at-nc-state/developers/accessibility-handbook/aria-landmarks/) have been utilized where applicable.
- ARIA attributes have been put into use.
- Any custom controls have been given the proper role attribute.
- State changes are provided via [ARIA states](http://www.w3.org/TR/wai-aria/states_and_properties#attrs_widgets_header).
- Form input fields and buttons have been labeled for screen reader users.

## Color
_< 1 hour_
- Text has sufficient color contrast against its background.
- Contrast ratio of 4.5:1 for normal text (less than 18 point or 14 point bold.)
- Contrast ratio of 3:1 for large text (at least 18 point or 14 point bold).
- Information conveyed via color is also available by other means.
- Buttons and links are visually apparent when they have focus.
- Focus remains apparent, and contrast remains sufficient, when simulating varying types of colorblindness. [Color blind simulators](https://www.toptal.com/designers/colorfilter)

## UX Design Considerations
- Interactions available with a mouse are also available using a keyboard.
- Information conveyed visually is also available by other means.
- Pop-ups and other state changes are announced to screen readers using appropriate ARIA attributes.
- Temporary on-screen events give users ample time to receive conveyed information.
- Animations are not excessively flashy, as this can cause seizures in some users.

## Tools and Resources
Use a variety of testing tools to analyze pages:
- aXe developer tools by Deque
- Browser developer tools to inspect HTML for logical heading structure and ARIA roles
- [Color blind simulators](https://www.toptal.com/designers/colorfilter)
24 changes: 20 additions & 4 deletions docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,24 +6,40 @@ The following are guidelines for contributing to this project.

## Code of Conduct

This repository is governed by Mozilla's code of conduct and etiquette guidelines. For more details please see the [Mozilla Community Participation Guidelines](https://www.mozilla.org/about/governance/policies/participation/) and [Developer Etiquette Guidelines](https://bugzilla.mozilla.org/page.cgi?id=etiquette.html).
This repository is governed by Mozilla's code of conduct and etiquette guidelines. For more details please see the [Mozilla Community Participation Guidelines][community-guidelines] and [Developer Etiquette Guidelines][etiquette-guidelines].

## How to Get Started

Please refer to installation and build instructions in the [install documentation](install.md).

## How to Report Bugs

Please open [a new issue in the appropriate GitHub repository](https://github.com/mozilla-lockbox/lockbox-extension/issues/new) with steps to reproduce the problem you're experiencing.
Please open [a new issue in the appropriate GitHub repository][new-issue] with steps to reproduce the problem you're experiencing.

Be sure to include as much information including screenshots, text output, and both your expected and actual results.

## How to Request Enhancements

First, please refer to the applicable [GitHub repository](https://github.com/orgs/mozilla-lockbox/) and search [the repository's GitHub issues](https://github.com/mozilla-lockbox/lockbox-extension/issues) to make sure your idea has not been (or is not still) considered. It may also be easier to see and search across all projects combined on our [Waffle.io planning board](https://waffle.io/mozilla-lockbox/lockbox-extension).
First, please refer to the applicable [GitHub repository][github-repos] and search [the repository's GitHub issues][issues-list] to make sure your idea has not been (or is not still) considered. It may also be easier to see and search across all projects combined on our [Waffle.io planning board][waffle].

Then, please [create a new issue in the GitHub repository](https://github.com/mozilla-lockbox/lockbox-extension/issues/new) describing your enhancement.
Then, please [create a new issue in the GitHub repository][new-issue] describing your enhancement.

Be sure to include as much detail as possible including step-by-step descriptions, specific examples, screenshots or mockups, and reasoning for why the enhancement might be worthwhile.

Please keep in mind, by opening an issue we provide no guarantee the enhancement will be implemented.

## How to Contribute Code

Before you get started writing code, be sure what you plan to work on is something we'll be able to accept. The easiest way is to look through out list of [good first issues][good-first-issues] and find something that sounds interesting.

If there's something else you'd like to work on, just add a comment in the relevant issue and we'll be happy to discuss your plans. If you have an idea that doesn't have an issue at all, be sure to [file an issue](#how-to-request-enhancements) first.

Once you have a patch ready, submit a pull request and request a review from **@mozilla-lockbox/engineering**. From there, we'll guide you through the review process to the eventual landing of your code! We aim to respond to all review requests within two business days.

[community-guidelines]: https://www.mozilla.org/about/governance/policies/participation/
[etiquette-guidelines]: https://bugzilla.mozilla.org/page.cgi?id=etiquette.html
[new-issue]: https://github.com/mozilla-lockbox/lockbox-extension/issues/new
[github-repos]: https://github.com/orgs/mozilla-lockbox/
[issues-list]: https://github.com/mozilla-lockbox/lockbox-extension/issues
[waffle]: https://waffle.io/mozilla-lockbox/lockbox-extension
[good-first-issues]: https://github.com/mozilla-lockbox/lockbox-extension/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
2 changes: 1 addition & 1 deletion docs/faqs.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ The alpha version of Lockbox hasn’t been tested widely with other password man

## Do Lockbox entries sync to other computers with Lockbox installed?

Yes, if you secure Lockbox with a Firefox Account.
No, not currently.

## Can I try Lockbox if I don’t have a Mozilla.com email address?

Expand Down
Loading

0 comments on commit 6da39d8

Please sign in to comment.