Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

klog should accept an optional enum in InitLogger and defaults reading from env if not provided #7

Open
nadeemkhedr opened this issue Aug 7, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@nadeemkhedr
Copy link
Contributor

Find the code here:

switch strings.ToUpper(os.Getenv("LOG_LEVEL")) {

Goal: is to add an enum that InitLogger would accept and would set the logging level from it, if an enum is not provided, keep the logic as-is (read it from env var)

This will make it easy for other services to provide the logging level especially if they don't have .env setup yet

@nadeemkhedr nadeemkhedr added the enhancement New feature or request label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant