Fixed a crash that could result daily for some players. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the game itself sets it to null at some point. Another mod maybe. Did you actually catch the crash? Have a crash report? |
|
It probably is, but I didn't go through to figure out which mod was causing it. The reports were submitted to me on my discord, and the user also posted them on the Nexus Mod Page |
|
It could be anything. Probably from another thread. In that case your code is not right way to fix it. You need some sort of thread locking. But to do so it is necessary to fully understand what's going on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably happens when the tick runs while the ruling clan leader is dead and the logic to set the new one hasn't happened yet, but it's unclear.