Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SOLR support #15

Merged
merged 16 commits into from
Apr 13, 2024
Merged

Add SOLR support #15

merged 16 commits into from
Apr 13, 2024

Conversation

reekitconcept
Copy link
Member

@reekitconcept reekitconcept commented Mar 15, 2024

  • add dependency to collective person and a person type
  • add behaviour to extend person type, by default disabled
  • add profile for collective.solr which will be our solr search setup for intranets
  • add setup handler as added by cookiecutter

@reekitconcept reekitconcept added the enhancement New feature or request label Mar 15, 2024
@reekitconcept reekitconcept changed the title WIP add solr support WIP add SOLR support Mar 15, 2024
@reekitconcept reekitconcept changed the title WIP add SOLR support WIP Add SOLR support Mar 15, 2024
@reekitconcept reekitconcept changed the title WIP Add SOLR support Add SOLR support Mar 25, 2024
@reekitconcept
Copy link
Member Author

This is ready for first review, points to consider:

  • is the scaffold ok now, ie. everything removed that needs to be? @ericof
  • is the included person type ok? @tisto

Right now the behavior to define extra fields in the person type is not active by default but can easily be done so from tests / demo site. - My objective is being able to demonstrate the solr sidebar facet conditions. But that can be done in different ways as well. (One possibility is city / zipcode instead of building / room. but that also requires a behavior to extend the person type.)

Further steps:

  • example content with which we can demo solr, feedback of @tisto ?
  • cypress tests in collective.solr based on this setup, @reebalazs.
  • ... ?

@tisto
Copy link
Member

tisto commented Mar 28, 2024

@reebalazs adding c.person as a dependency is fine with me. I'd say let's merge this asap. Let's try to set up the demo instance and then I am more than happy to give detailed feedback and plan the next steps.

@tisto tisto merged commit 7c2b45f into main Apr 13, 2024
5 checks passed
@tisto tisto deleted the ree-add-solr-support branch April 13, 2024 08:22
@tisto tisto mentioned this pull request Apr 13, 2024
@tisto tisto restored the ree-add-solr-support branch May 17, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants