Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Example content of Teaser-Slider Block #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iRohitSingh
Copy link
Member

@iRohitSingh
Copy link
Member Author

Teaser-Slider-Block (2)

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stop. The old plone.distribution import/export format makes this impossible to review. There are too many changed lines to tell whether it is only making the intended change, or also other changes.

@iFlameing previously worked on this in #33 and #34 which had the same problem.

I asked for us to switch to the new plone.exportimport format because it puts each content item in a separate file. That conversion is in progress in #36 but needs more work. (I know Alok asked for help with this -- sorry I didn't find time to help yet. Maybe @ericof can.)

We need to finish switching to plone.exportimport before we try to fix anything in the actual content. Otherwise we'll likely break something each time we fix something else. /cc @sneridagh @tisto

@tisto
Copy link
Member

tisto commented Jun 28, 2024

@davisagli thank you for brining this up! Then we should indeed first solve this problem properly before moving on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants