set modifiers of all final enum constants to be public #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi thanks for bringing this package up to date 🙏
I wanted to filter some indexes using the Enum variable for IndexType (eg
IndexType::primary
) but noticed that these modifiers were all set to private, which means they are only accessible in their own namespace.These are constant anyway, so I figured it would make sense to make all of these
Enum
s public.Having these public would make me allow to filter the primary keys on a table like such: