Clear out gitea access in the frontend

Only ednpoints needed for rendering projects are left.

frontend/package.json

@@ -20,7 +20,6 @@
     "meilisearch": "^0.25.1",
     "morgan": "^1.10.0",
     "next": "^12.1.6",
-    "node-fetch": "2",
     "prop-types": "^15.7.2",
     "raw-loader": "^4.0.0",
     "react": "^17.0.2",

frontend/src/components/SharedProjectPage/elements.jsx

@@ -11,14 +11,12 @@ import Readme from '@components/Board/Readme'
 const PageElements = ({
   assetPath,
   repoName,
-  hasUploadPermission,
   hasIBOM,
   kitspaceYAML,
   bomInfo,
   zipUrl,
   readme,
   boardSpecs,
-  previewOnly,
   description,
   projectName,
   projectFullname,
@@ -28,18 +26,6 @@ const PageElements = ({
   readmeExists,
   boardShowcaseAssetsExist,
 }) => {
-  const AssetPlaceholderWithUploadPermissions = ({ asset }) => (
-    <AssetPlaceholder
-      asset={asset}
-      hasUploadPermission={hasUploadPermission}
-      previewOnly={previewOnly}
-    />
-  )
-
-  AssetPlaceholderWithUploadPermissions.propTypes = {
-    asset: string.isRequired,
-  }
-
   return (
     <>
       <InfoBar
@@ -59,7 +45,7 @@ const PageElements = ({
             />
           </>
         ) : (
-          <AssetPlaceholderWithUploadPermissions asset="board" />
+          <AssetPlaceholder asset="board" />
         )}
       </div>
       <div>
@@ -70,7 +56,7 @@ const PageElements = ({
             zipUrl={zipUrl}
           />
         ) : (
-          <AssetPlaceholderWithUploadPermissions asset="gerber files" />
+          <AssetPlaceholder asset="gerber files" />
         )}
         {bomInfoExists ? (
           <BuyParts
@@ -79,29 +65,23 @@ const PageElements = ({
             projectFullName={projectFullname}
           />
         ) : (
-          <AssetPlaceholderWithUploadPermissions asset="bill of materials" />
+          <AssetPlaceholder asset="bill of materials" />
         )}
       </div>
       <div>
         {readmeExists ? (
           <Readme renderedReadme={readme} />
         ) : (
-          <AssetPlaceholderWithUploadPermissions asset="README" />
+          <AssetPlaceholder asset="README" />
         )}
       </div>
     </>
   )
 }
 
-const AssetPlaceholder = ({ asset, hasUploadPermission, previewOnly }) => {
+const AssetPlaceholder = ({ asset }) => {
   let message = `No ${asset} files were found`
 
-  if (hasUploadPermission && previewOnly) {
-    message += ', commit files to the original repo and it will be synced'
-  } else if (hasUploadPermission && !previewOnly) {
-    message += ', upload some'
-  }
-
   return (
     <div
       style={{
@@ -122,13 +102,10 @@ const AssetPlaceholder = ({ asset, hasUploadPermission, previewOnly }) => {
 
 AssetPlaceholder.propTypes = {
   asset: string.isRequired,
-  hasUploadPermission: bool.isRequired,
-  previewOnly: bool.isRequired,
 }
 
 PageElements.propTypes = {
   assetPath: string.isRequired,
-  hasUploadPermission: bool.isRequired,
   hasIBOM: bool.isRequired,
   kitspaceYAML: shape({
     summary: string,

frontend/src/components/SharedProjectPage/index.jsx

@@ -1,6 +1,6 @@
 import React, { useEffect, useState } from 'react'
 import { useRouter } from 'next/router'
-import { Loader, Message } from 'semantic-ui-react'
+import { Loader } from 'semantic-ui-react'
 
 import Page from '@components/Page'
 import { useMigrationStatus } from '@hooks/Gitea'
@@ -73,16 +73,6 @@ const SharedProjectPage = props => {
 
   return (
     <Page title={title}>
-      {props.isSynced && props.hasUploadPermission ? (
-        <Message color="yellow" data-cy="sync-msg">
-          <Message.Header>A synced repository!</Message.Header>
-          <Message.Content>
-            <p>Files uploading isn&apos;t supported for synced repositories.</p>
-            Please commit files to the original git repository and it will be synced
-            automatically.
-          </Message.Content>
-        </Message>
-      ) : null}
       <PageElements
         {...props}
         assetPath={`${props.rootAssetPath}/${props.projectName}`}
@@ -104,7 +94,6 @@ SharedProjectPage.propTypes = {
   isEmpty: bool.isRequired,
   finishedProcessing: bool.isRequired,
   isSynced: bool.isRequired,
-  hasUploadPermission: bool.isRequired,
 }
 
 export default SharedProjectPage

frontend/src/hooks/useForm.ts

@@ -1,9 +1,7 @@
-import { useState, useContext, useCallback, useEffect } from 'react'
-import { AuthContext } from '@contexts/AuthContext'
+import { useState, useCallback, useEffect } from 'react'
 import { Schema } from 'joi'
 
 export default function UseForm(schema: Schema, validateOnBlur?: boolean) {
-  const { csrf } = useContext(AuthContext)
   const [form, setForm] = useState<any>({})
   const [formValidationErrors, setFormValidationErrors] = useState<any>([])
   /*
@@ -19,13 +17,11 @@ export default function UseForm(schema: Schema, validateOnBlur?: boolean) {
 
     if (isCheckBox) {
       setForm(prevForm => ({
-        _csrf: csrf,
         ...prevForm,
         [data.name]: data.checked,
       }))
     } else {
       setForm(prevForm => ({
-        _csrf: csrf,
         ...prevForm,
         [event.target.name]: data.value,
       }))
@@ -50,10 +46,10 @@ export default function UseForm(schema: Schema, validateOnBlur?: boolean) {
      */
     (data, predicate = true) => {
       if (predicate) {
-        setForm({ _csrf: csrf, ...data })
+        setForm(data)
       }
     },
-    [csrf],
+    [],
   )
 
   const isValid = Object.keys(formValidationErrors).length === 0

frontend/src/pages/[user]/[repo]/[project]/index.jsx

@@ -2,7 +2,7 @@ import React from 'react'
 import { bool } from 'prop-types'
 import getConfig from 'next/config'
 
-import { canCommit, getRepo, repoExists } from '@utils/giteaApi'
+import { getRepo, repoExists } from '@utils/giteaApi'
 import {
   getBoardBomInfo,
   getBoardGerberInfo,
@@ -19,14 +19,13 @@ const assetUrl = getConfig().publicRuntimeConfig.KITSPACE_ASSET_URL
 const MultiProjectPage = props =>
   props.notFound ? <Custom404 /> : <SharedProjectPage {...props} />
 
-MultiProjectPage.getInitialProps = async ({ query, req = null, res = null }) => {
+MultiProjectPage.getInitialProps = async ({ query, res = null }) => {
   const { user: username, repo: repoName, project: projectName } = query
 
   const repoFullName = `${username}/${repoName}`
 
   const rootAssetPath = `${assetUrl}/files/${repoFullName}/HEAD`
   const assetPath = `${rootAssetPath}/${projectName}`
-  const session = req?.session ?? JSON.parse(sessionStorage.getItem('session'))
 
   const exists = await repoExists(repoFullName)
   if (exists) {
@@ -38,7 +37,6 @@ MultiProjectPage.getInitialProps = async ({ query, req = null, res = null }) =>
       [kitspaceYAMLExists, kitspaceYamlArray],
       finishedProcessing,
       hasIBOM,
-      hasUploadPermission,
     ] = await Promise.all([
       getRepo(repoFullName),
       getReadme(assetPath),
@@ -47,8 +45,6 @@ MultiProjectPage.getInitialProps = async ({ query, req = null, res = null }) =>
       getKitspaceYamlArray(rootAssetPath),
       getIsProcessingDone(rootAssetPath),
       hasInteractiveBom(assetPath),
-      // The repo owner and collaborators can upload files.
-      canCommit(repoFullName, session.user?.username, session.apiToken),
     ])
 
     const kitspaceYAML = kitspaceYamlArray.find(p => p.name === projectName)
@@ -68,7 +64,6 @@ MultiProjectPage.getInitialProps = async ({ query, req = null, res = null }) =>
       rootAssetPath,
       repo,
       projectFullname: repoFullName,
-      hasUploadPermission,
       hasIBOM,
       kitspaceYAML,
       zipUrl,

frontend/src/pages/_app.jsx

@@ -30,7 +30,6 @@ import 'semantic-ui-css/components/dimmer.min.css'
 import 'semantic-ui-css/components/table.min.css'
 import 'semantic-ui-css/components/progress.min.css'
 
-import AuthProvider from '@contexts/AuthContext'
 import './_app.scss'
 
 if (typeof window !== 'undefined') {
@@ -42,7 +41,7 @@ if (typeof window !== 'undefined') {
     }
 }
 
-function KitspaceApp({ Component, pageProps, session, isStaticFallback }) {
+function KitspaceApp({ Component, pageProps, isStaticFallback }) {
   const setStaticFallback = isStaticFallback ? (
     <script
       // using dangerouslySetInnerHTML to avoid browser parsing errors
@@ -57,25 +56,21 @@ function KitspaceApp({ Component, pageProps, session, isStaticFallback }) {
     isStaticFallback = isStaticFallback || window.isStaticFallback
   }
   return (
-    <AuthProvider initialSession={session}>
+    <>
       <Head>{setStaticFallback}</Head>
       <Component {...pageProps} />
       {isStaticFallback ? <ErrorMessage /> : null}
-    </AuthProvider>
+    </>
   )
 }
 
 KitspaceApp.getInitialProps = async appContext => {
   const appProps = await App.getInitialProps(appContext)
 
   const { isStaticFallback } = appContext.ctx.query
-  const session =
-    appContext.ctx?.req?.session ??
-    JSON.parse(window?.sessionStorage.getItem('session'))
 
   return {
     ...appProps,
-    session,
     isStaticFallback,
   }
 }

frontend/src/server.js

@@ -2,7 +2,6 @@
 const express = require('express')
 const morgan = require('morgan')
 const next = require('next')
-const fetch = require('node-fetch')
 const port = parseInt(process.env.PORT, 10) || 3000
 const dev = process.env.NODE_ENV !== 'production'
 const hostname = process.env.KITSPACE_DOMAIN
@@ -26,9 +25,6 @@ async function main() {
   }
 
   server.all('*', async (req, res, next) => {
-    req.session = await fetch('http://gitea:3000/user/kitspace/session', {
-      headers: { ...req.headers, accept: 'application/json' },
-    }).then(r => r.json())
     nextHandler(req, res, next)
   })