From d7411d480551a11a4c911450271eae5a90a535d1 Mon Sep 17 00:00:00 2001
From: AbdulrhmnGhanem <abdoghanem160@gmail.com>
Date: Fri, 29 Oct 2021 17:07:05 +0200
Subject: [PATCH] Fix: 1-click-bom extion message handling

---
 .../src/components/Board/BuyParts/index.jsx   | 133 +++++++++---------
 1 file changed, 66 insertions(+), 67 deletions(-)

diff --git a/frontend/src/components/Board/BuyParts/index.jsx b/frontend/src/components/Board/BuyParts/index.jsx
index 4f2adeae60..6e6d84be83 100644
--- a/frontend/src/components/Board/BuyParts/index.jsx
+++ b/frontend/src/components/Board/BuyParts/index.jsx
@@ -1,4 +1,4 @@
-import React, { useEffect, useState } from 'react'
+import React, { useEffect, useRef, useState } from 'react'
 import { array, bool, func, number, string } from 'prop-types'
 import OneClickBom from '1-click-bom-minimal'
 import { Header, Icon, Segment, Input, Button } from 'semantic-ui-react'
@@ -9,17 +9,71 @@ import DirectStores from './DirectStores'
 import styles from './index.module.scss'
 
 const BuyParts = ({ projectFullName, lines, parts }) => {
-  const [extensionPresence, setExtensionPresence] = useState('unknown')
-  // it's needed to fix the extension integration.
-  // eslint-disable-next-line  @typescript-eslint/no-unused-vars
-  const [buyParts, setBuyParts] = useState(null)
+  const extensionPresence = useRef('unknown')
+  const [buyParts, setBuyParts] = useState(() => install1ClickBOM)
   const [buyMultiplier, setBuyMultiplier] = useState(1)
   const [mult, setMult] = useState(1)
   const [buyAddPercent, setBuyAddPercent] = useState(0)
   const [adding, setAdding] = useState({})
 
-  const retailerList = OneClickBom.getRetailers()
-  const retailerButtons = retailerList
+  useEffect(() => {
+    const multi = buyMultiplier
+    if (Number.isNaN(multi) || multi < 1) {
+      setMult(1)
+    }
+    const percent = buyAddPercent
+    if (Number.isNaN(percent) || percent < 1) {
+      setMult(0)
+    }
+    setMult(multi + multi * (percent / 100))
+  }, [buyMultiplier, buyAddPercent])
+
+  useEffect(() => {
+    const handleExtensionMessages = event => {
+      if (event.source !== window) {
+        return
+      }
+
+      if (event.data.from === 'extension') {
+        extensionPresence.current = 'present'
+        switch (event.data.message) {
+          case 'register':
+            setBuyParts(() => retailer => {
+              window.plausible('Buy Parts', {
+                props: {
+                  project: projectFullName,
+                  vendor: retailer,
+                  multiplier: mult,
+                },
+              })
+              window.postMessage(
+                {
+                  from: 'page',
+                  message: 'quickAddToCart',
+                  value: {
+                    retailer,
+                    multiplier: mult,
+                  },
+                },
+                '*',
+              )
+            })
+            break
+          case 'updateAddingState':
+            setAdding(event.data.value)
+            break
+          default:
+            break
+        }
+      }
+    }
+
+    window.addEventListener('message', handleExtensionMessages)
+
+    return () => window.removeEventListener('message', handleExtensionMessages)
+  }, [mult, projectFullName])
+
+  const retailerButtons = OneClickBom.getRetailers()
     .map(name => {
       const [numberOfLines, numberOfParts] = lines.reduce(
         ([numOfLines, numOfParts], line) => {
@@ -35,8 +89,10 @@ const BuyParts = ({ projectFullName, lines, parts }) => {
           <RetailerButton
             key={name}
             adding={adding[name]}
-            buyParts={() => install1ClickBOM()}
-            extensionPresence={name === 'Digikey' ? 'absent' : extensionPresence}
+            buyParts={() => buyParts(name)}
+            extensionPresence={
+              name === 'Digikey' ? 'absent' : extensionPresence.current
+            }
             name={name}
             numberOfLines={numberOfLines}
             numberOfParts={numberOfParts}
@@ -48,63 +104,6 @@ const BuyParts = ({ projectFullName, lines, parts }) => {
     })
     .filter(l => l != null)
 
-  useEffect(() => {
-    // extension communication
-    window.addEventListener(
-      'message',
-      event => {
-        if (event.source !== window) {
-          return
-        }
-        if (event.data.from === 'extension') {
-          setExtensionPresence('present')
-          switch (event.data.message) {
-            case 'register':
-              setBuyParts(retailer => {
-                window.plausible('Buy Parts', {
-                  props: {
-                    project: projectFullName,
-                    vendor: retailer,
-                    multiplier: mult,
-                  },
-                })
-                window.postMessage(
-                  {
-                    from: 'page',
-                    message: 'quickAddToCart',
-                    value: {
-                      retailer,
-                      multiplier: mult,
-                    },
-                  },
-                  '*',
-                )
-              })
-              break
-            case 'updateAddingState':
-              setAdding(event.data.value)
-              break
-            default:
-              break
-          }
-        }
-      },
-      false,
-    )
-  }, [mult, projectFullName])
-
-  useEffect(() => {
-    const multi = buyMultiplier
-    if (Number.isNaN(multi) || multi < 1) {
-      setMult(1)
-    }
-    const percent = buyAddPercent
-    if (Number.isNaN(percent) || percent < 1) {
-      setMult(0)
-    }
-    setMult(multi + multi * (percent / 100))
-  }, [buyMultiplier, buyAddPercent])
-
   const linesToTsv = () => {
     const linesMult = lines.map(line => ({
       ...line,
@@ -121,7 +120,7 @@ const BuyParts = ({ projectFullName, lines, parts }) => {
       </Header>
       {hasPurchasableParts ? (
         <>
-          <InstallPrompt extensionPresence={extensionPresence} />
+          <InstallPrompt extensionPresence={extensionPresence.current} />
           <AdjustQuantity
             buyAddPercent={buyAddPercent}
             buyMultiplier={buyMultiplier}