Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1-click-bom extension integration #125

Closed
AbdulrhmnGhanem opened this issue May 29, 2021 · 5 comments · Fixed by #587
Closed

Fix 1-click-bom extension integration #125

AbdulrhmnGhanem opened this issue May 29, 2021 · 5 comments · Fixed by #587
Labels
bug Something isn't working core core features
Milestone

Comments

@AbdulrhmnGhanem
Copy link
Member

No description provided.

@kasbah
Copy link
Member

kasbah commented Jun 10, 2021

I've uploaded v1.7.4 of the extension which gives access to kitspace.dev and kitspace.test:3000. It's available on Firefox, Chrome might take a bit longer to appear.

@kasbah
Copy link
Member

kasbah commented Jun 18, 2021

Port :3000 isn't allowed in Chrome for some reason so I had to upload a v1.7.5 version with just the kitspace.test domain (i.e. port 80). kitspace.dev is still enabled though and it's been released.

@kasbah kasbah added this to the alpha-1 milestone Jul 18, 2021
@AbdulrhmnGhanem AbdulrhmnGhanem changed the title Fix 1-click-bom extension integration. Fix 1-click-bom extension integration Aug 3, 2021
@kasbah kasbah modified the milestones: alpha-1, alpha-2 Nov 7, 2022
@AbdulrhmnGhanem
Copy link
Member Author

I will add a /1-click-BOM.tsv route to the project page and make it redirect the actual asset URL. This will let us control the asset URL without modifying the extension, just change the redirect URL.

@kasbah, what do you think of this?

@kasbah
Copy link
Member

kasbah commented Nov 15, 2022 via email

@kasbah
Copy link
Member

kasbah commented May 28, 2023

I've added the /1-click-BOM.tsv route and fixed up the extension integration with #587. I've also updated 1clickBOM and pushed a new version to Google and Mozilla extension stores. Once #587 is merged in and new extensions are approved by the stores we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core core features
Projects
None yet
2 participants