Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1clickBOM extension integration #224

Closed
wants to merge 2 commits into from
Closed

1clickBOM extension integration #224

wants to merge 2 commits into from

Conversation

AbdulrhmnGhanem
Copy link
Member

Fixes #125

@AbdulrhmnGhanem AbdulrhmnGhanem temporarily deployed to staging October 29, 2021 18:29 Inactive
@AbdulrhmnGhanem
Copy link
Member Author

@kasbah, something is unclear to me on clicking on any store button the quickAddToCart message gets posted the updateAddingState fields are always false or undefined indicated below.

image
I tried it on kitsapce.org and the clicked store gets set to `true. Am I missing something?

@kasbah
Copy link
Member

kasbah commented Oct 30, 2021

As discussed on call, 1clickBOM needs to be udpated to retrieve the 1-click-BOM.tsv from the processor.

@AbdulrhmnGhanem AbdulrhmnGhanem temporarily deployed to staging November 16, 2022 06:52 Inactive
@AbdulrhmnGhanem AbdulrhmnGhanem temporarily deployed to staging November 16, 2022 08:37 Inactive
@AbdulrhmnGhanem AbdulrhmnGhanem temporarily deployed to staging November 16, 2022 09:03 Inactive
@AbdulrhmnGhanem AbdulrhmnGhanem temporarily deployed to staging November 16, 2022 10:59 Inactive
@AbdulrhmnGhanem
Fix: 1-click-bom extion message handling
d7411d4
@AbdulrhmnGhanem
Make the 1-click-bom.tsv file accessible to the 1-click-bom extension.
643d0ea 
The 1-click-bom extension tries loading the `1-click-BOM.tsv` file by
`GET`ing `[...projecURL]/1-click-BOM.tsx`.
But we have the file in the processor (or later on s3) so using this
approach will let us control the actual `1-click-BOM.tsv` file URL
without re-modifying the extension.
@AbdulrhmnGhanem
Copy link
Member Author

kitspace/1clickBOM#40

@AbdulrhmnGhanem AbdulrhmnGhanem added this to the alpha-2 milestone Feb 24, 2023
@AbdulrhmnGhanem AbdulrhmnGhanem mentioned this pull request Jun 27, 2023
Merged
@kasbah
Copy link
Member

kasbah commented Jul 4, 2023

Superseded by #587

@AbdulrhmnGhanem AbdulrhmnGhanem deleted the one-click-bom branch July 22, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
alpha-2
Development

Successfully merging this pull request may close these issues.

Fix 1-click-bom extension integration
2 participants
@AbdulrhmnGhanem @kasbah