Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect up 1-click-BOM extension #587

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Connect up 1-click-BOM extension #587

merged 3 commits into from
Jun 28, 2023

Conversation

kasbah
Copy link
Member

@kasbah kasbah commented May 26, 2023 •
edited by AbdulrhmnGhanem
Loading

fixes #125

@kasbah kasbah temporarily deployed to staging May 26, 2023 22:02 — with GitHub Actions Inactive
@kasbah kasbah temporarily deployed to staging May 26, 2023 22:07 — with GitHub Actions Inactive
@kasbah kasbah force-pushed the ke/extension-bom branch 2 times, most recently from 57757a0 to b0a62e2 Compare May 27, 2023 20:02
@kasbah kasbah changed the title Add 1-click-BOM.tsv path for the extension Connect up 1-click-BOM extension May 27, 2023
@kasbah kasbah mentioned this pull request May 28, 2023
Closed
@AbdulrhmnGhanem
Copy link
Member

and replaces #224

@AbdulrhmnGhanem
Copy link
Member

AbdulrhmnGhanem commented Jun 27, 2023 •
edited
Loading

In #224, I added a redirect

source: '/:user/:repo/1-click-BOM.tsv',
destination: '/:user/:repo/_/1-click-BOM.tsv',

we don't need it? is it handled by the extension now?

@kasbah
Copy link
Member Author

kasbah commented Jun 28, 2023

yep

@AbdulrhmnGhanem AbdulrhmnGhanem merged commit 3799789 into master Jun 28, 2023
@AbdulrhmnGhanem AbdulrhmnGhanem deleted the ke/extension-bom branch June 29, 2023 12:53
@kasbah kasbah mentioned this pull request Jul 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix 1-click-bom extension integration
2 participants
@kasbah @AbdulrhmnGhanem