Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change moduleResolution from node to bundler #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

d2verb
Copy link

@d2verb d2verb commented Jan 1, 2025

see:

"bundler" option allows us to import module without extension (e.g., we can write import "foo" instead of import "foo.ts")

@d2verb
Copy link
Author

d2verb commented Jan 1, 2025

I made this PR because I ran into the following error when using this library.

Cannot find module '/Users/...(snip).../node_modules/.pnpm/scrambling-ascii-art@1.0.0_react@18.3.1/node_modules/scrambling-ascii-art/dist/index' imported from /Users/...(snip).../node_modules/.pnpm/scrambling-ascii-art@1.0.0_react@18.3.1/node_modules/scrambling-ascii-art/dist/react.js
    at finalizeResolution (node:internal/modules/esm/resolve:265:11)
    at moduleResolve (node:internal/modules/esm/resolve:933:10)
    at defaultResolve (node:internal/modules/esm/resolve:1169:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:542:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:510:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:239:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:96:40)
    at link (node:internal/modules/esm/module_job:95:36

@kiwamizamurai kiwamizamurai added the bug Something isn't working label Jan 1, 2025
@kiwamizamurai
Copy link
Owner

Thank you for your information
Let me check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants