Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove overrides for PyGithub #86

Merged
merged 4 commits into from
May 6, 2024
Merged

Remove overrides for PyGithub #86

merged 4 commits into from
May 6, 2024

Commits on May 5, 2024

  1. Remove the GithubKiwiTCMSBot() class 

    integration with GitHub will be only via app-token
    @atodorov
    atodorov committed May 5, 2024
    Configuration menu
    Copy the full SHA
    f526818 View commit details
    Browse the repository at this point in the history

  2. Simplify self.requester override in PatchedGithub() 

    use the rules for name mangling to get access to the attribute we need
and simplify the whole inherited class to reduce interface mismatch
with newer versions of the library
    @atodorov
    atodorov committed May 5, 2024
    Configuration menu
    Copy the full SHA
    0a7d623 View commit details
    Browse the repository at this point in the history

  3. Start using the new GitHub Auth parameters introduced in PyGithub==1.… 

    …59.0
    @atodorov
    atodorov committed May 5, 2024
    Configuration menu
    Copy the full SHA
    15c390d View commit details
    Browse the repository at this point in the history

  4. Silence pylint on name-mangled attributes 

    see 0a7d623

The attribute name is Github.__requester which is automatically
converted at runtime to ._Github__requester!
    @atodorov
    atodorov committed May 5, 2024
    Configuration menu
    Copy the full SHA
    b0f6b48 View commit details
    Browse the repository at this point in the history