-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write fragments into pormake input format #130
Comments
would also be nice to then add some functionality to pormake to update the database |
actually, for placing the dummy atoms it would be useful to extend the "dummy molecules" in the molecules in PR #152 even more (because we would add the atom the carboxy-C binds to as dummy and to avoid geometry analysis we could just take the right distance and orientation from the structure) |
Hi, |
Hi @vthost, thanks for your interest! This is not yet implemented in the general case (I have some development code but got sidetracked with another project). In principle, One difficulty is that the dummy atom definition is different in the MOF-assembly code from what I use here internally. I know that some people have their own internal tools that they do not want to share, but they are often limited to carboxy-linkers. If you need this urgently, I'd be happy to help you implement this with |
Thank you for the explanation! |
I experimented a bit, but I think it would be hard to use it within |
Yes, the fragmentation is done differently, and you would need to use some of the private attributes saved in the building blocks to reconstruct the building blocks in the poremake format. One could use this to write the building blocks in the pormake format (that was the reason this information is stored with the building blocks). However, this requires coding and testing for edge cases (e.g., non-carboxy building blocks). I got distracted by other projects and do not see myself working on this until April. I can provide some pointers on where to look, but I won't have the time to do much coding and debugging myself. If this doesn't work for you, you might want to look into other MOF fragmentation tools, such as mBUD. |
No description provided.
The text was updated successfully, but these errors were encountered: