Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cobra for argument parsing + shell completions #22

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pomdtr
Copy link

@pomdtr pomdtr commented Sep 28, 2023

Beeing able to have completion for --session flags is quite nice.

See the kks completion command for setup instructions.

@kkga
Copy link
Owner

kkga commented Sep 28, 2023

woah, this is a big PR. Thanks for the contribution! TBH, I'm not quite sure that something like completions for --session deserves an integration of cobra. The original approach was simple and worked fine without adding any extra dependencies.
Are there any other obvious benefits aside from the completions?
Also worth noting that I'm not actively using Kakoune these days and thus not using this tool as well.

@pomdtr
Copy link
Author

pomdtr commented Sep 28, 2023

Basically all the doc is now autogenerated, and you get completions for everything (not just the session, also the command names / flags).

If you are no longer using kakoune, I could maybe maintain my fork instead ?
I feel like this cli (or connect.kak / kakoune.cr) is a core component of the kakoune experience (akin to kak-lsp), so I really want a maintained version of it to exists / be universally available.

@pomdtr
Copy link
Author

pomdtr commented Sep 28, 2023

I personally mostly used vscode with the dance extension, but I'm still reaching for kakoune on a daily basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants