Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding surface error on Ellipsoidal mirror #194

Open
leahwang1962 opened this issue Aug 6, 2024 · 2 comments
Open

adding surface error on Ellipsoidal mirror #194

leahwang1962 opened this issue Aug 6, 2024 · 2 comments

Comments

@leahwang1962
Copy link

Hi, need more help to add surface error on the Ellipsoidal mirror following last week's topic. Basically copy your warp.py of Gaussian bump(ray),local_z_distorted(self, x, y), local_n_distorted(self, x, y). But the surface 3D goes back to partially display and the ray tracing results seems to me show sections of ellipsoidal are not involved in the reflection.
3DWithoutSurfaceError
3DWithGaussianbump
AtOpticExit_noError
AtOpticExit_addGaussianBump
Gaussianbump
Thanks.

@kklmn
Copy link
Owner

kklmn commented Aug 6, 2024

docs

@leahwang1962
Copy link
Author

Thanks for the docs. After some tests, I found in def gaussian_bump(self) after changing #x = np.linspace(-opticcenterR, opticcenterR, nX) to
x = np.linspace(-1000, 1000, nX) , the closed circle of ellipsoidal shows correctly now, and the simulation results are reasonable. It makes sense because in def gaussian_bump(self), x = np.linspace(-opticcenterR, opticcenterR, nX) changes the optics' x limits. Now the problem is how to build the gaussian_bump surface error on this closed circle. Do you think the XY mesh grid method is still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants