Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minus (like -3) is minified with a space which leads to an error #5

Closed
blb4github opened this issue Nov 27, 2024 · 2 comments · Fixed by #6
Closed

minus (like -3) is minified with a space which leads to an error #5

blb4github opened this issue Nov 27, 2024 · 2 comments · Fixed by #6

Comments

@blb4github
Copy link
Contributor

blb4github commented Nov 27, 2024

One of code lines is:
#RoomTempControl = round(#RoomTempDelta * -3);

When this line is minified it is changed to:
#RTC = round(#RTD * - 3);
with option -c:
#RoomTempControl = round(#RoomTempDelta * - 3);

This is leading to an error, if I change the output lines manually to:
#RTC = round(#RTD * -3);
or
#RoomTempControl = round(#RoomTempDelta * -3);
it is accepted.

update:
I have now done a work around:
$multiplier = -3; #RoomTempControl = round(#RoomTempDelta * $multiplier);

@klaashoekstra94
Copy link
Owner

Good to see that this project is still being used :)
And good catch of that bug, It should hopefully be fixed by PR #6. I already made a new release (v0.0.4), so you should be able to just update it using pip to test it.

@blb4github
Copy link
Contributor Author

Thanks for fixing it, I have installed the new version and it's working perfect now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants