flate, zstd: Shave some bytes off amd64 matchLen #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XORQ sets the flags, so there is no need for TESTQ. Use a 32-bit shift after TZCNT/BSF.
klauspost
approved these changes
May 30, 2024
MrAlias
referenced
this pull request
in open-telemetry/opentelemetry-go-contrib
Jun 17, 2024
…5760) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/klauspost/compress](https://togithub.com/klauspost/compress) | `v1.17.8` -> `v1.17.9` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>klauspost/compress (github.com/klauspost/compress)</summary> ### [`v1.17.9`](https://togithub.com/klauspost/compress/releases/tag/v1.17.9) [Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.8...v1.17.9) ##### What's Changed - s2: Reduce ReadFrom temporary allocations by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/compress/pull/949](https://togithub.com/klauspost/compress/pull/949) - Fix arm64 vet issues by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/compress/pull/964](https://togithub.com/klauspost/compress/pull/964) - flate, zstd: Shave some bytes off amd64 matchLen by [@​greatroar](https://togithub.com/greatroar) in [https://github.com/klauspost/compress/pull/963](https://togithub.com/klauspost/compress/pull/963) - Upgrade zip to 1.22.4 upstream by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/compress/pull/970](https://togithub.com/klauspost/compress/pull/970) - zstd: BuildDict fails with RLE table by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/compress/pull/951](https://togithub.com/klauspost/compress/pull/951) - Upgrade zlib to upstream by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/compress/pull/971](https://togithub.com/klauspost/compress/pull/971) **Full Changelog**: klauspost/compress@v1.17.8...v1.17.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector
Jun 18, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/klauspost/compress](https://togithub.com/klauspost/compress) | `v1.17.8` -> `v1.17.9` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>klauspost/compress (github.com/klauspost/compress)</summary> ### [`v1.17.9`](https://togithub.com/klauspost/compress/releases/tag/v1.17.9) [Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.8...v1.17.9) ##### What's Changed - s2: Reduce ReadFrom temporary allocations by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/compress/pull/949](https://togithub.com/klauspost/compress/pull/949) - Fix arm64 vet issues by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/compress/pull/964](https://togithub.com/klauspost/compress/pull/964) - flate, zstd: Shave some bytes off amd64 matchLen by [@​greatroar](https://togithub.com/greatroar) in [https://github.com/klauspost/compress/pull/963](https://togithub.com/klauspost/compress/pull/963) - Upgrade zip to 1.22.4 upstream by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/compress/pull/970](https://togithub.com/klauspost/compress/pull/970) - zstd: BuildDict fails with RLE table by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/compress/pull/951](https://togithub.com/klauspost/compress/pull/951) - Upgrade zlib to upstream by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/compress/pull/971](https://togithub.com/klauspost/compress/pull/971) **Full Changelog**: klauspost/compress@v1.17.8...v1.17.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
dmitryax
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Jun 19, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/klauspost/compress](https://togithub.com/klauspost/compress) | `v1.17.8` -> `v1.17.9` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>klauspost/compress (github.com/klauspost/compress)</summary> ### [`v1.17.9`](https://togithub.com/klauspost/compress/releases/tag/v1.17.9) [Compare Source](https://togithub.com/klauspost/compress/compare/v1.17.8...v1.17.9) ##### What's Changed - s2: Reduce ReadFrom temporary allocations by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/compress/pull/949](https://togithub.com/klauspost/compress/pull/949) - Fix arm64 vet issues by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/compress/pull/964](https://togithub.com/klauspost/compress/pull/964) - flate, zstd: Shave some bytes off amd64 matchLen by [@​greatroar](https://togithub.com/greatroar) in [https://github.com/klauspost/compress/pull/963](https://togithub.com/klauspost/compress/pull/963) - Upgrade zip to 1.22.4 upstream by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/compress/pull/970](https://togithub.com/klauspost/compress/pull/970) - zstd: BuildDict fails with RLE table by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/compress/pull/951](https://togithub.com/klauspost/compress/pull/951) - Upgrade zlib to upstream by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/klauspost/compress/pull/971](https://togithub.com/klauspost/compress/pull/971) **Full Changelog**: klauspost/compress@v1.17.8...v1.17.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only ran a few benchmarks and did not see a speedup, but the code is a bit shorter.