Skip to content

sapemu: Implement tcall #672

sapemu: Implement tcall

sapemu: Implement tcall #672

Triggered via push September 7, 2024 13:04
Status Failure
Total duration 1m 34s
Artifacts

rust.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

8 errors and 18 warnings
casts from `u8` to `u16` can be expressed infallibly using `From`: sapemu/src/smp.rs#L465
error: casts from `u8` to `u16` can be expressed infallibly using `From` --> sapemu/src/smp.rs:465:3 | 465 | self.sp as u16 + 0x100 | ^^^^^^^^^^^^^^ | = help: an `as` cast can become silently lossy if the types change in the future = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless help: use `u16::from` instead | 465 | u16::from(self.sp) + 0x100 | ~~~~~~~~~~~~~~~~~~
this could be a `const fn`: sapemu/src/smp.rs#L464
error: this could be a `const fn` --> sapemu/src/smp.rs:464:2 | 464 | / pub fn stack_top(&self) -> u16 { 465 | | self.sp as u16 + 0x100 466 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn note: the lint level is defined here --> sapemu/src/main.rs:2:62 | 2 | #![deny(missing_docs, unused, clippy::all, clippy::pedantic, clippy::nursery, rustdoc::all)] | ^^^^^^^^^^^^^^^ = note: `#[deny(clippy::missing_const_for_fn)]` implied by `#[deny(clippy::nursery)]` help: make the function `const` | 464 | pub const fn stack_top(&self) -> u16 { | +++++
this method could have a `#[must_use]` attribute: sapemu/src/smp.rs#L464
error: this method could have a `#[must_use]` attribute --> sapemu/src/smp.rs:464:2 | 464 | pub fn stack_top(&self) -> u16 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn stack_top(&self) -> u16` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate = note: `#[deny(clippy::must_use_candidate)]` implied by `#[deny(clippy::pedantic)]`
casts from `u8` to `u16` can be expressed infallibly using `From`: sapemu/src/smp/ops.rs#L1828
error: casts from `u8` to `u16` can be expressed infallibly using `From` --> sapemu/src/smp/ops.rs:1828:31 | 1828 | let upper_target_address = cpu.read(call_address + 1, memory) as u16; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: an `as` cast can become silently lossy if the types change in the future = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless help: use `u16::from` instead | 1828 | let upper_target_address = u16::from(cpu.read(call_address + 1, memory)); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
casts from `u8` to `u16` can be expressed infallibly using `From`: sapemu/src/smp/ops.rs#L1825
error: casts from `u8` to `u16` can be expressed infallibly using `From` --> sapemu/src/smp/ops.rs:1825:49 | 1825 | MicroArchAction::Continue(state.with_address(lower_target_address as u16)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: an `as` cast can become silently lossy if the types change in the future = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless help: use `u16::from` instead | 1825 | MicroArchAction::Continue(state.with_address(u16::from(lower_target_address))) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
this match arm has an identical body to another arm: sapemu/src/smp/ops.rs#L1817
error: this match arm has an identical body to another arm --> sapemu/src/smp/ops.rs:1817:3 | 1817 | 2 => MicroArchAction::Continue(state), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try changing either arm body = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms = note: `#[deny(clippy::match_same_arms)]` implied by `#[deny(clippy::pedantic)]` help: or try merging the arm patterns | 1817 | 2 | 4 => MicroArchAction::Continue(state), | ~~~~~ help: and remove this obsolete arm | 1822 - 4 => MicroArchAction::Continue(state), |
casts from `u8` to `u16` can be expressed infallibly using `From`: sapemu/src/smp/ops.rs#L1807
error: casts from `u8` to `u16` can be expressed infallibly using `From` --> sapemu/src/smp/ops.rs:1807:30 | 1807 | let call_address = 0xFFDE - INDEX as u16 * 2; | ^^^^^^^^^^^^ | = help: an `as` cast can become silently lossy if the types change in the future = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless note: the lint level is defined here --> sapemu/src/main.rs:2:44 | 2 | #![deny(missing_docs, unused, clippy::all, clippy::pedantic, clippy::nursery, rustdoc::all)] | ^^^^^^^^^^^^^^^^ = note: `#[deny(clippy::cast_lossless)]` implied by `#[deny(clippy::pedantic)]` help: use `u16::from` instead | 1807 | let call_address = 0xFFDE - u16::from(INDEX) * 2; | ~~~~~~~~~~~~~~~~
clippy
Clippy had exited with the 101 exit code
fmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
fmt
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1.0.7. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1, actions-rs/clippy-check@v1.0.7. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/