sapemu: Implement shifts on direct page #683
kleinesfilmroellchenAnnotations
6 errors and 21 warnings
|
this argument is a mutable reference, but not used mutably:
sapemu/src/smp/ops.rs#L2193
error: this argument is a mutable reference, but not used mutably
--> sapemu/src/smp/ops.rs:2193:10
|
2193 | memory: &mut Memory,
| ^^^^^^^^^^^ help: consider changing to: `&Memory`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
= note: `-D clippy::needless-pass-by-ref-mut` implied by `-D clippy::nursery`
= help: to override `-D clippy::nursery` add `#[allow(clippy::needless_pass_by_ref_mut)]`
|
|
item in documentation is missing backticks:
sapemu/src/test.rs#L201
error: item in documentation is missing backticks
--> sapemu/src/test.rs:201:47
|
201 | /// Tests that are not run due to issues with SingleStepTest's disregard of hardware properties.
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
= note: `-D clippy::doc-markdown` implied by `-D clippy::pedantic`
= help: to override `-D clippy::pedantic` add `#[allow(clippy::doc_markdown)]`
help: try
|
201 | /// Tests that are not run due to issues with `SingleStepTest`'s disregard of hardware properties.
| ~~~~~~~~~~~~~~~~
|
|
this could be a `const fn`:
sapemu/src/smp.rs#L429
error: this could be a `const fn`
--> sapemu/src/smp.rs:429:2
|
429 | / fn carry(&self) -> bool {
430 | | self.psw.contains(ProgramStatusWord::Carry)
431 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn
help: make the function `const`
|
429 | const fn carry(&self) -> bool {
| +++++
|
|
casting to the same type is unnecessary (`u16` -> `u16`):
sapemu/src/smp/ops.rs#L2091
error: casting to the same type is unnecessary (`u16` -> `u16`)
--> sapemu/src/smp/ops.rs:2091:50
|
2091 | MicroArchAction::Continue(state.with_address2(address as u16))
| ^^^^^^^^^^^^^^ help: try: `address`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-D clippy::unnecessary-cast` implied by `-D clippy::all`
= help: to override `-D clippy::all` add `#[allow(clippy::unnecessary_cast)]`
|
|
this could be a `const fn`:
sapemu/src/smp/ops.rs#L1696
error: this could be a `const fn`
--> sapemu/src/smp/ops.rs:1696:1
|
1696 | / fn increment_wrap_within_page(address: u16) -> u16 {
1697 | | let low_byte_increment = (address & 0xff).wrapping_add(1) & 0xff;
1698 | | address & 0xff00 | low_byte_increment
1699 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn
= note: `-D clippy::missing-const-for-fn` implied by `-D clippy::nursery`
= help: to override `-D clippy::nursery` add `#[allow(clippy::missing_const_for_fn)]`
help: make the function `const`
|
1696 | const fn increment_wrap_within_page(address: u16) -> u16 {
| +++++
|
|
clippy
Clippy had exited with the 101 exit code
|
|
fmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
fmt
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt
The process '/usr/bin/git' failed with exit code 128
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The process '/usr/bin/git' failed with exit code 128
|
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1.0.7. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1, actions-rs/clippy-check@v1.0.7. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy
The process '/usr/bin/git' failed with exit code 128
|