Skip to content

sapemu: DAS is a mess #704

sapemu: DAS is a mess

sapemu: DAS is a mess #704

Triggered via push September 28, 2024 16:18
Status Failure
Total duration 1m 54s
Artifacts

rust.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 21 warnings
casts from `bool` to `u8` can be expressed infallibly using `From`: sapemu/src/smp.rs#L480
error: casts from `bool` to `u8` can be expressed infallibly using `From` --> sapemu/src/smp.rs:480:60 | 480 | let half_carry_result = (op1 & 0x0f) + ((!op2) & 0x0f) + self.carry() as u8 >= 0x10; | ^^^^^^^^^^^^^^^^^^ | = help: an `as` cast can become silently lossy if the types change in the future = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless help: use `u8::from` instead | 480 | let half_carry_result = (op1 & 0x0f) + ((!op2) & 0x0f) + u8::from(self.carry()) >= 0x10; | ~~~~~~~~~~~~~~~~~~~~~~
casts from `bool` to `u16` can be expressed infallibly using `From`: sapemu/src/smp.rs#L474
error: casts from `bool` to `u16` can be expressed infallibly using `From` --> sapemu/src/smp.rs:474:68 | 474 | let expanded_result = (op1 as u16).wrapping_add((!op2) as u16) + self.carry() as u16; | ^^^^^^^^^^^^^^^^^^^ | = help: an `as` cast can become silently lossy if the types change in the future = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless help: use `u16::from` instead | 474 | let expanded_result = (op1 as u16).wrapping_add((!op2) as u16) + u16::from(self.carry()); | ~~~~~~~~~~~~~~~~~~~~~~~
casts from `u8` to `u16` can be expressed infallibly using `From`: sapemu/src/smp.rs#L474
error: casts from `u8` to `u16` can be expressed infallibly using `From` --> sapemu/src/smp.rs:474:51 | 474 | let expanded_result = (op1 as u16).wrapping_add((!op2) as u16) + self.carry() as u16; | ^^^^^^^^^^^^^ | = help: an `as` cast can become silently lossy if the types change in the future = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless help: use `u16::from` instead | 474 | let expanded_result = (op1 as u16).wrapping_add(u16::from((!op2))) + self.carry() as u16; | ~~~~~~~~~~~~~~~~~
casts from `u8` to `u16` can be expressed infallibly using `From`: sapemu/src/smp.rs#L474
error: casts from `u8` to `u16` can be expressed infallibly using `From` --> sapemu/src/smp.rs:474:25 | 474 | let expanded_result = (op1 as u16).wrapping_add((!op2) as u16) + self.carry() as u16; | ^^^^^^^^^^^^ | = help: an `as` cast can become silently lossy if the types change in the future = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless help: use `u16::from` instead | 474 | let expanded_result = u16::from(op1).wrapping_add((!op2) as u16) + self.carry() as u16; | ~~~~~~~~~~~~~~
casts from `bool` to `u8` can be expressed infallibly using `From`: sapemu/src/smp.rs#L462
error: casts from `bool` to `u8` can be expressed infallibly using `From` --> sapemu/src/smp.rs:462:57 | 462 | let half_carry_result = (op1 & 0x0f) + (op2 & 0x0f) + self.carry() as u8 >= 0x10; | ^^^^^^^^^^^^^^^^^^ | = help: an `as` cast can become silently lossy if the types change in the future = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless = note: `-D clippy::cast-lossless` implied by `-D clippy::pedantic` = help: to override `-D clippy::pedantic` add `#[allow(clippy::cast_lossless)]` help: use `u8::from` instead | 462 | let half_carry_result = (op1 & 0x0f) + (op2 & 0x0f) + u8::from(self.carry()) >= 0x10; | ~~~~~~~~~~~~~~~~~~~~~~
this operation has no effect: sapemu/src/smp/ops.rs#L1969
error: this operation has no effect --> sapemu/src/smp/ops.rs:1969:12 | 1969 | cpu.y = (modulus & 0xff) as u8; | ^^^^^^^^^^^^^^^^ help: consider reducing it to: `modulus` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
casting to the same type is unnecessary (`u8` -> `u8`): sapemu/src/smp/ops.rs#L1969
error: casting to the same type is unnecessary (`u8` -> `u8`) --> sapemu/src/smp/ops.rs:1969:12 | 1969 | cpu.y = (modulus & 0xff) as u8; | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(modulus & 0xff)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
this operation has no effect: sapemu/src/smp/ops.rs#L1968
error: this operation has no effect --> sapemu/src/smp/ops.rs:1968:12 | 1968 | cpu.a = (div & 0xff) as u8; | ^^^^^^^^^^^^ help: consider reducing it to: `div` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
casting to the same type is unnecessary (`u8` -> `u8`): sapemu/src/smp/ops.rs#L1968
error: casting to the same type is unnecessary (`u8` -> `u8`) --> sapemu/src/smp/ops.rs:1968:12 | 1968 | cpu.a = (div & 0xff) as u8; | ^^^^^^^^^^^^^^^^^^ help: try: `(div & 0xff)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `-D clippy::unnecessary-cast` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::unnecessary_cast)]`
this operation has no effect: sapemu/src/smp/ops.rs#L1965
error: this operation has no effect --> sapemu/src/smp/ops.rs:1965:42 | 1965 | cpu.psw.set(ProgramStatusWord::Sign, ((div & 0xff) as i8) < 0); | ^^^^^^^^^^^^ help: consider reducing it to: `div` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op = note: `-D clippy::identity-op` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::identity_op)]`
clippy
Clippy had exited with the 101 exit code
fmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
fmt
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
fmt
The process '/usr/bin/git' failed with exit code 128
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The process '/usr/bin/git' failed with exit code 128
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1.0.7. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1, actions-rs/clippy-check@v1.0.7. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The process '/usr/bin/git' failed with exit code 128