Add read barrier in background thread. #285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pevab
reviewed
Aug 22, 2023
| val inventory = assessment.inventory() | ||
| val (trace, assessment, inventory) = | ||
| runReadAction { | ||
| val rTrace = traceSystemWithIndicator(progress, file, processName, matchLabels) |
There was a problem hiding this comment.
il y a déjà un runReadAction dans traceSystemWithIndicators
There was a problem hiding this comment.
Du coup tu suggères quoi on l'enlève de traceSystem ?
Je pense que ça ne pose pas de pb d'avoir une read action dans une autre vu qu'il a déjà le lock.
Ou alors tu est serein sur le fait que toutes les manipulations de Psi sont fait juste dans cette méthode et je reverse cette partie ?
There was a problem hiding this comment.
oui je suggère qu'on merge pas la PR
La lecture du PSI est déjà protégée par runReadAction (cf. le code de traceSystemWithIndicator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading Psi file, we have to setup
read barrierfrom a background thread.From https://developerlife.com/2021/03/13/ij-idea-plugin-advanced/#background-tasks-and-multiple-threads---the-correct-way