Bypass rollback #7
Conversation
| } | ||
| const secondsFromPurchase = Date.now() / 1000 - firstPurchase.timestamp | ||
| // Estimated time to bypass a rollback | ||
| if (secondsFromPurchase <= 60) { |
| @@ -27,6 +28,15 @@ export async function* getNotifications( | |||
| const addressJettonsFromDb = await getJettonsFromDB(wallet.id) | |||
| for (const jetton of addressJettonsFromDb) { | |||
| if (!addressJettonsFromChainObj[jetton.token]) { | |||
| const firstPurchase = await getFirstAddressJettonPurchaseFromDB(jetton.id) | |||
| if (!firstPurchase) { | |||
There was a problem hiding this comment.
Is this possible? If we think it's not, we need to log this.
There was a problem hiding this comment.
This is technically possible. if we have a race condition.
I replaced multiple queries with a single postgres transaction with these queries to completly avoid that possibility now.
src/utils/parseTxData/api.ts
Outdated
| @@ -21,7 +21,9 @@ export const api = async (address: string) => { | |||
| res[jettonInfo.symbol] = { | |||
| ...jettonInfo, | |||
| pnlPercentage, | |||
| chart: (slicedChart.length >= 2 ? slicedChart : chart).reverse().map(entity => [entity[0], normalizePrice(entity[1], jettonInfo.decimals)]), | |||
| chart: (slicedChart.length >= 2 ? slicedChart : chart) | |||
There was a problem hiding this comment.
If slicedChart does not have at least two elements, that means our algorithm is wrong. log it as error.
There was a problem hiding this comment.
Do not reverse the chart here. Reverse it on the frontend
There was a problem hiding this comment.
I just didn't touch that, but sure.
src/utils/parseTxData/api.ts
Outdated
| chart: (slicedChart.length >= 2 ? slicedChart : chart).reverse().map(entity => [entity[0], normalizePrice(entity[1], jettonInfo.decimals)]), | ||
| chart: (slicedChart.length >= 2 ? slicedChart : chart) | ||
| .reverse() | ||
| .map(entity => [entity[0], normalizePrice(entity[1], jettonInfo.decimals)]), |
There was a problem hiding this comment.
This logic should not be here. return the literal price value, and normalize it on the frontend. Less load on the server + eventually I want to turn it into a string (not valid number at all), e.g. something like 0.₉1234
There was a problem hiding this comment.
Actually, frontend is completely ok with displaying a string. But I guess our clients have decent hardware and don't care about some client-side transformations anyway.
No description provided.