Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test maglev test suite #1141

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hzxuzhonghu
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1137

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hzxuzhonghu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 76.74419% with 10 lines in your changes missing coverage. Please review.

Project coverage is 51.83%. Comparing base (8197d65) to head (cd55a9b).
Report is 154 commits behind head on main.

Files with missing lines Patch % Lines
pkg/consistenthash/maglev/maglev.go 82.85% 4 Missing and 2 partials ⚠️
pkg/cache/v2/cluster.go 50.00% 3 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
pkg/bpf/ads/loader.go 38.02% <ø> (+1.54%) ⬆️
pkg/bpf/ads/sock_connection.go 55.46% <ø> (ø)
pkg/cache/v2/cluster.go 43.87% <50.00%> (+0.62%) ⬆️
pkg/consistenthash/maglev/maglev.go 70.00% <82.85%> (+1.34%) ⬆️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4104f3...cd55a9b. Read the comment docs.

@@ -69,11 +72,14 @@ func NewClusterCache(bpfAds *bpfads.BpfAds, hashName *utils.HashName) ClusterCac
apiClusterCache[Cluster.Name] = &cluster_v2.Cluster{}
}
}

m, _ := maglev.InitMaglevMap(maglevOuter)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore the error return value here because there is no error?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should handle the error

Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestMaglevTestSuite influence other test
3 participants