-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test maglev test suite #1141
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
pkg/cache/v2/cluster.go
Outdated
@@ -69,11 +72,14 @@ func NewClusterCache(bpfAds *bpfads.BpfAds, hashName *utils.HashName) ClusterCac | |||
apiClusterCache[Cluster.Name] = &cluster_v2.Cluster{} | |||
} | |||
} | |||
|
|||
m, _ := maglev.InitMaglevMap(maglevOuter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore the error return value here because there is no error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should handle the error
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1137
Special notes for your reviewer:
Does this PR introduce a user-facing change?: