Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion is always at the end of the text #2

Open
asdofindia opened this issue Dec 11, 2023 · 4 comments
Open

Suggestion is always at the end of the text #2

asdofindia opened this issue Dec 11, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@asdofindia
Copy link

Screenshot_2023-12-11-07-51-49-00_3aea4af51f236e4932235fdada7d1643

Introduced by the workaround on #1 I think.

You can probably add only till end of word into the span.
@knadh knadh added the bug Something isn't working label Dec 11, 2023
@knadh
Copy link
Owner

knadh commented Dec 11, 2023

Darn ;( Will look at this soon (unless you've a bit of time to spend on a PR).

@Mesfrum
Copy link

Mesfrum commented Feb 12, 2024

Hey @knadh, can I submit a PR? If anyone has not looked into this yet?

@knadh
Copy link
Owner

knadh commented Feb 13, 2024

@Mesfrum sure.

Mesfrum added a commit to Mesfrum/floatype.js that referenced this issue Feb 24, 2024
@Mesfrum
Fix issue knadh#2 : Modify caret handling in shadow element
b93fb6c
Mesfrum added a commit to Mesfrum/floatype.js that referenced this issue Feb 24, 2024
@Mesfrum
Fix issue knadh#2
6ead916
@Mesfrum Mesfrum mentioned this issue Feb 24, 2024
Closed
@MarketingPip
Copy link

@Mesfrum - tested your PR. Does not fix issue.

Mesfrum added a commit to Mesfrum/floatype.js that referenced this issue Jul 10, 2024
@Mesfrum
Merge branch 'master' into fix-issue-knadh#2
b317f27
non-engineer-dev added a commit to non-engineer-dev/floatype.js that referenced this issue Aug 25, 2024
@non-engineer-dev
Fix suggestion is always at the end of the text (issue knadh#2)
c475b3e
knadh added a commit that referenced this issue Aug 26, 2024
@knadh
Merge pull request #7 from non-engineer-dev/fix-issue-2
6304665 
Fix suggestion is always at the end of the text (issue #2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #2 Mesfrum/floatype.js
4 participants
@knadh @asdofindia @MarketingPip @Mesfrum