Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more options #35

Merged
merged 7 commits into from
Aug 5, 2024
Merged

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Jul 29, 2024

Changes

  • Add support for extra Prometheus triggers and scaled modifiers
  • Allows to pass a scaled object directly via annotations in autocreate (managed mode).
  • Adds documentation for the configuration options, annotations etc
  • Minor clean up

Fixes #20
Fixes #32
Fixes #33

Release Note

Add support for extra Prometheus triggers and scaled modifiers. Allow to pass a scaled object directly via annotations in auto-create (managed mode).

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 29, 2024
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 29, 2024
@skonto skonto requested review from dsimansk and removed request for izabelacg July 29, 2024 12:51
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 62.94643% with 83 lines in your changes missing coverage. Please review.

Project coverage is 73.46%. Comparing base (3691e64) to head (e851413).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/autoscaling/hpa/helpers/helpers.go 33.33% 40 Missing and 2 partials ⚠️
pkg/reconciler/autoscaling/hpa/resources/keda.go 77.50% 20 Missing and 7 partials ⚠️
...onciler/autoscaling/hpa/resources/scaled_object.go 63.15% 8 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   83.28%   73.46%   -9.83%     
==========================================
  Files           8        8              
  Lines         359      520     +161     
==========================================
+ Hits          299      382      +83     
- Misses         43      108      +65     
- Partials       17       30      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2024
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 31, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2024
@skonto skonto changed the title [WIP] Allow more options Allow more options Aug 5, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2024
CONCEPTS-API.md Outdated Show resolved Hide resolved
CONCEPTS-API.md Outdated Show resolved Hide resolved
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See distinct comments.

@skonto
Copy link
Contributor Author

skonto commented Aug 5, 2024

/hold testing scale to zero

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2024
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2024
Copy link

knative-prow bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto
Copy link
Contributor Author

skonto commented Aug 5, 2024

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2024
@knative-prow knative-prow bot merged commit f303a12 into knative-extensions:main Aug 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for multiple Prometheus Triggers Support all metric types Add support for combination of metrics
3 participants