-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support scale to zero #55
Conversation
129f2eb
to
13881fe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
- Coverage 73.46% 72.77% -0.69%
==========================================
Files 8 8
Lines 520 518 -2
==========================================
- Hits 382 377 -5
- Misses 108 110 +2
- Partials 30 31 +1 ☔ View full report in Codecov by Sentry. |
names.Service = svc.Name | ||
|
||
// Wait before getting the objects | ||
time.Sleep(30 * time.Second) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't get the resources from service status as it is not ready until we get metrics. So we just wait. Can be improved in another PR to actually fetch the objects when they are ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Similarly the scaledobject shows to be inactive.
/kind enhancement
Fixes #15
Release Note