Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e test infrastructure #82

Merged
merged 5 commits into from
Sep 18, 2024
Merged

e2e test infrastructure #82

merged 5 commits into from
Sep 18, 2024

Conversation

aliok
Copy link
Member

@aliok aliok commented Sep 17, 2024 •
edited
Loading

This PR sets up the e2e test infrastructure.

There's a dummy test, which will be changed into a real e2e test later on.

Check individual commits.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 17, 2024

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 17, 2024
@aliok aliok force-pushed the 2024-09-17-security-e2e-tests branch 3 times, most recently from bdf2485 to 472b331 Compare September 17, 2024 20:10
@aliok
E2E test infrastructure
1bf0e32 
Signed-off-by: Ali Ok <aliok@redhat.com>
@aliok
Check in vendored files
ea73c24 
Signed-off-by: Ali Ok <aliok@redhat.com>
@aliok aliok force-pushed the 2024-09-17-security-e2e-tests branch from 230209e to ea73c24 Compare September 18, 2024 06:18
@aliok aliok changed the title WIP: Backend security e2e tests e2e test infrastructure Sep 18, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@aliok aliok requested a review from pierDipi September 18, 2024 06:35
aliok
aliok commented Sep 18, 2024
View reviewed changes
third_party/eventing-latest/eventing-core.yaml Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that the files in this folder need to be updated using automation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we do that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, found it: knative-extensions/eventing-kafka-broker#4094

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be addressed later with #83

@aliok aliok mentioned this pull request Sep 18, 2024
Closed
@aliok
Update eventing core and crd files
715df3a 
Signed-off-by: Ali Ok <aliok@redhat.com>
@aliok
Add IMC and MTC broker manifests
35f2fa1 
Signed-off-by: Ali Ok <aliok@redhat.com>
pierDipi
pierDipi reviewed Sep 18, 2024
View reviewed changes
hack/control-plane.sh Outdated Show resolved Hide resolved
hack/control-plane.sh Outdated Show resolved Hide resolved
hack/artifacts-env.sh Outdated Show resolved Hide resolved
test/config/100-config-logging.yaml Outdated Show resolved Hide resolved
test/config/100-config-logging.yaml Outdated Show resolved Hide resolved
test/e2e-common.sh Outdated Show resolved Hide resolved
test/e2e-tests.sh Outdated Show resolved Hide resolved
test/e2e-common.sh Outdated Show resolved Hide resolved
test/e2e-common.sh Outdated Show resolved Hide resolved
test/e2e-common.sh Outdated Show resolved Hide resolved
pierDipi
pierDipi reviewed Sep 18, 2024
View reviewed changes
hack/tools.go Outdated Show resolved Hide resolved
@aliok @pierDipi
Suggestions
395750d 
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@aliok aliok force-pushed the 2024-09-17-security-e2e-tests branch from f8856a2 to 395750d Compare September 18, 2024 10:34
@pierDipi
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
@knative-prow knative-prow bot merged commit c062137 into knative-extensions:main Sep 18, 2024
23 checks passed
@aliok aliok deleted the 2024-09-17-security-e2e-tests branch September 18, 2024 11:17
@aliok aliok mentioned this pull request Sep 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi left review comments

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliok @pierDipi