Skip to content

Allow enabling sarama logging and disabling client pool #8749

Allow enabling sarama logging and disabling client pool

Allow enabling sarama logging and disabling client pool #8749

Triggered via pull request September 17, 2024 15:06
Status Failure
Total duration 3m 38s
Artifacts

knative-style.yaml

on: pull_request
style  /  changes
3s
style / changes
style  /  ...  /  Auto-format and Check
13s
style / Golang / Auto-format and Check
style  /  ...  /  Lint
3m 12s
style / Golang / Lint
style  /  ...  /  Do Not Submit
7s
style / Golang / Do Not Submit
style  /  ...  /  shell
0s
style / suggester / shell
style  /  ...  /  yaml
28s
style / suggester / yaml
style  /  ...  /  github_actions
0s
style / suggester / github_actions
Matrix: style / Golang / Boilerplate Check
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 5 warnings
style / Golang / Auto-format and Check: control-plane/cmd/kafka-controller/main.go#L1
Please run goimports. diff --git a/control-plane/cmd/kafka-controller/main.go b/control-plane/cmd/kafka-controller/main.go index df4a3e7..0e2d833 100644 --- a/control-plane/cmd/kafka-controller/main.go +++ b/control-plane/cmd/kafka-controller/main.go @@ -75,10 +75,10 @@ func main() { ) if v := os.Getenv("ENABLE_SARAMA_LOGGER"); strings.EqualFold(v, "true") { - sarama.Logger = log.New(os.Stdout, "[sarama] ", log.LstdFlags | log.Llongfile) + sarama.Logger = log.New(os.Stdout, "[sarama] ", log.LstdFlags|log.Llongfile) } if v := os.Getenv("ENABLE_SARAMA_DEBUG_LOGGER"); strings.EqualFold(v, "true") { - sarama.DebugLogger = log.New(os.Stdout, "[sarama][debug] ", log.LstdFlags | log.Llongfile) + sarama.DebugLogger = log.New(os.Stdout, "[sarama][debug] ", log.LstdFlags|log.Llongfile) } if v := os.Getenv("ENABLE_SARAMA_CLIENT_POOL"); v == "" || strings.EqualFold(v, "true") { ctx = clientpool.WithKafkaClientPool(ctx)
style / Golang / Auto-format and Check: control-plane/pkg/reconciler/channel/controller.go#L1
Please run goimports. diff --git a/control-plane/pkg/reconciler/channel/controller.go b/control-plane/pkg/reconciler/channel/controller.go index d586eee..87d5c53 100644 --- a/control-plane/pkg/reconciler/channel/controller.go +++ b/control-plane/pkg/reconciler/channel/controller.go @@ -83,14 +83,14 @@ func NewController(ctx context.Context, watcher configmap.Watcher, configs *conf DataPlaneNamespace: configs.SystemNamespace, ReceiverLabel: base.ChannelReceiverLabel, }, - Env: configs, - ConfigMapLister: configmapInformer.Lister(), - ServiceLister: serviceinformer.Get(ctx).Lister(), - SubscriptionLister: subscriptioninformer.Get(ctx).Lister(), - ConsumerGroupLister: consumerGroupInformer.Lister(), - EventPolicyLister: eventPolicyInformer.Lister(), - InternalsClient: consumergroupclient.Get(ctx), - KafkaFeatureFlags: apisconfig.DefaultFeaturesConfig(), + Env: configs, + ConfigMapLister: configmapInformer.Lister(), + ServiceLister: serviceinformer.Get(ctx).Lister(), + SubscriptionLister: subscriptioninformer.Get(ctx).Lister(), + ConsumerGroupLister: consumerGroupInformer.Lister(), + EventPolicyLister: eventPolicyInformer.Lister(), + InternalsClient: consumergroupclient.Get(ctx), + KafkaFeatureFlags: apisconfig.DefaultFeaturesConfig(), } clientPool := clientpool.Get(ctx)
style / Golang / Auto-format and Check: control-plane/pkg/reconciler/sink/controller.go#L1
Please run goimports. diff --git a/control-plane/pkg/reconciler/sink/controller.go b/control-plane/pkg/reconciler/sink/controller.go index 192ad38..0e41d5e 100644 --- a/control-plane/pkg/reconciler/sink/controller.go +++ b/control-plane/pkg/reconciler/sink/controller.go @@ -70,9 +70,9 @@ func NewController(ctx context.Context, watcher configmap.Watcher, configs *conf DataPlaneNamespace: configs.SystemNamespace, ReceiverLabel: base.SinkReceiverLabel, }, - ConfigMapLister: configmapInformer.Lister(), - EventPolicyLister: eventPolicyInformer.Lister(), - Env: configs, + ConfigMapLister: configmapInformer.Lister(), + EventPolicyLister: eventPolicyInformer.Lister(), + Env: configs, } clientPool := clientpool.Get(ctx)
style / Golang / Auto-format and Check
Process completed with exit code 1.
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-kafka-broker/eventing-kafka-broker. Supported file pattern: go.sum
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-kafka-broker/eventing-kafka-broker. Supported file pattern: go.sum
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-kafka-broker/eventing-kafka-broker. Supported file pattern: go.sum
style / suggester / yaml
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-kafka-broker/eventing-kafka-broker. Supported file pattern: go.sum