Skip to content

Commit

Permalink
Remove e2e test dependency on injection informers
Browse files Browse the repository at this point in the history
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
  • Loading branch information
pierDipi committed Sep 16, 2024
1 parent 76e67cd commit 6d82cc8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
5 changes: 0 additions & 5 deletions control-plane/pkg/reconciler/trigger/v2/triggerv2.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,6 @@ import (

const (
deliveryOrderAnnotation = "kafka.eventing.knative.dev/delivery.order"
// TopicPrefix is the Kafka Broker topic prefix - (topic name: knative-broker-<broker-namespace>-<broker-name>).
TopicPrefix = "knative-broker-"

// ExternalTopicAnnotation for using external kafka topic for the broker
ExternalTopicAnnotation = "kafka.eventing.knative.dev/external.topic"
)

type Reconciler struct {
Expand Down
8 changes: 4 additions & 4 deletions test/rekt/features/broker_deleted_recreated.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ package features

import (
"k8s.io/apimachinery/pkg/types"
kafkabroker "knative.dev/eventing-kafka-broker/control-plane/pkg/reconciler/broker"

"knative.dev/eventing-kafka-broker/test/e2e_new/bogus_config"
"knative.dev/eventing-kafka-broker/test/rekt/resources/kafkatopic"

Expand Down Expand Up @@ -111,7 +111,7 @@ func BrokerAuthSecretDoesNotExist() *feature.Feature {
broker.WithConfig(configName),
broker.WithAnnotations(
map[string]interface{}{
kafkabroker.ExternalTopicAnnotation: topicName,
"kafka.eventing.knative.dev/external.topic": topicName,
}))...))

f.Assert("delete broker", featuressteps.DeleteBroker(brokerName))
Expand All @@ -132,7 +132,7 @@ func BrokerExternalTopicDoesNotExist() *feature.Feature {
broker.WithEnvConfig(),
broker.WithAnnotations(
map[string]interface{}{
kafkabroker.ExternalTopicAnnotation: topicName,
"kafka.eventing.knative.dev/external.topic": topicName,
}))...))

f.Assert("delete broker", featuressteps.DeleteBroker(brokerName))
Expand Down Expand Up @@ -161,7 +161,7 @@ func BrokerExternalTopicAuthSecretDoesNotExist() *feature.Feature {
broker.WithConfig(configName),
broker.WithAnnotations(
map[string]interface{}{
kafkabroker.ExternalTopicAnnotation: topicName,
"kafka.eventing.knative.dev/external.topic": topicName,
}))...))

f.Assert("delete broker", featuressteps.DeleteBroker(brokerName))
Expand Down

0 comments on commit 6d82cc8

Please sign in to comment.