Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to kube_codegen.sh #4090

Merged

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Sep 2, 2024

As per title

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/control-plane area/test labels Sep 2, 2024
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 2, 2024
Copy link

knative-prow bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2024
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 41.93548% with 18 lines in your changes missing coverage. Please review.

Project coverage is 48.89%. Comparing base (b9233fe) to head (f45832a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...-plane/pkg/client/clientset/versioned/clientset.go 0.00% 6 Missing ⚠️
...e/pkg/client/informers/externalversions/generic.go 0.00% 4 Missing ⚠️
...lane/pkg/reconciler/consumergroup/consumergroup.go 50.00% 1 Missing and 1 partial ⚠️
control-plane/cmd/kafka-controller/main.go 0.00% 1 Missing ⚠️
...ternalskafkaeventing/v1alpha1/consumer/consumer.go 0.00% 1 Missing ⚠️
...fkaeventing/v1alpha1/consumer/filtered/consumer.go 0.00% 1 Missing ⚠️
...kaeventing/v1alpha1/consumergroup/consumergroup.go 0.00% 1 Missing ⚠️
...g/v1alpha1/consumergroup/filtered/consumergroup.go 0.00% 1 Missing ⚠️
...l-plane/pkg/reconciler/consumergroup/controller.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4090      +/-   ##
==========================================
+ Coverage   48.51%   48.89%   +0.38%     
==========================================
  Files         244      232      -12     
  Lines       14928    14680     -248     
==========================================
- Hits         7242     7178      -64     
+ Misses       6955     6779     -176     
+ Partials      731      723       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member Author

pierDipi commented Sep 2, 2024

 rbac.go:40: failed to create resource an error on the server ("Internal Server Error: \"/apis/rbac.authorization.k8s.io/v1/namespaces/test-ukvbbjir/rolebindings\": the server is currently unable to handle the request") has prevented the request from succeeding - Resource:

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Member Author

pierDipi commented Sep 6, 2024

+ go run github.com/charmbracelet/gum@v0.14.1 style --foreground 45
--- Cleaning up generated code' --dest=/logs/artifacts/junit_6fKyF10j.xml
/home/prow/go/src/knative.dev/eventing-kafka-broker/test/../vendor/knative.dev/hack/library.sh: line 697: /root/.gvm/gos/go1.22.6/bin/go: Argument list too long
+ return 1

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2024
@pierDipi
Copy link
Member Author

@cardil can you help here? I don't know what's the issue and I can't reproduce locally

@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 30, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2024
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi changed the title [WIP] Migrate to kube_codegen.sh Migrate to kube_codegen.sh Oct 9, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2024
@pierDipi
Copy link
Member Author

pierDipi commented Oct 9, 2024

/cc @creydr @matzew

@knative-prow knative-prow bot requested review from creydr and matzew October 9, 2024 08:23
@pierDipi
Copy link
Member Author

pierDipi commented Oct 9, 2024

/retest-required

1 similar comment
@pierDipi
Copy link
Member Author

pierDipi commented Oct 9, 2024

/retest-required

Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested via

find control-plane/pkg/apis -name 'zz_generated*' -delete
rm -r  control-plane/pkg/client/ 
./hack/update-codegen.sh

And no changes

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2024
@knative-prow knative-prow bot merged commit 0925c8c into knative-extensions:main Oct 9, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/test lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants