Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the name value for metrics tags to the correct top-level resource #4120

Merged

Set the `name` value for metrics tags to the correct top-level resource

16393a7
Select commit
Loading
Failed to load commit list.
Merged

Set the name value for metrics tags to the correct top-level resource #4120

Set the `name` value for metrics tags to the correct top-level resource
16393a7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 1, 2024 in 0s

48.51% (+0.03%) compared to f9f799c

View this Pull Request on Codecov

48.51% (+0.03%) compared to f9f799c

Details

Codecov Report

Attention: Patch coverage is 63.41463% with 15 lines in your changes missing coverage. Please review.

Project coverage is 48.51%. Comparing base (f9f799c) to head (16393a7).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
control-plane/pkg/reconciler/consumer/consumer.go 40.90% 10 Missing and 3 partials ⚠️
...ls/kafka/eventing/v1alpha1/consumer_group_types.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4120      +/-   ##
==========================================
+ Coverage   48.47%   48.51%   +0.03%     
==========================================
  Files         244      244              
  Lines       14888    14928      +40     
==========================================
+ Hits         7217     7242      +25     
- Misses       6943     6955      +12     
- Partials      728      731       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.