Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the name value for metrics tags to the correct top-level resource #4120

Merged

Set the `name` value for metrics tags to the correct top-level resource

16393a7
Select commit
Loading
Failed to load commit list.
Merged

Set the name value for metrics tags to the correct top-level resource #4120

Set the `name` value for metrics tags to the correct top-level resource
16393a7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Oct 1, 2024 in 0s

63.41% of diff hit (target 48.47%)

View this Pull Request on Codecov

63.41% of diff hit (target 48.47%)

Annotations

Check warning on line 222 in control-plane/pkg/apis/internals/kafka/eventing/v1alpha1/consumer_group_types.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

control-plane/pkg/apis/internals/kafka/eventing/v1alpha1/consumer_group_types.go#L221-L222

Added lines #L221 - L222 were not covered by tests

Check warning on line 136 in control-plane/pkg/reconciler/consumer/consumer.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

control-plane/pkg/reconciler/consumer/consumer.go#L136

Added line #L136 was not covered by tests

Check warning on line 318 in control-plane/pkg/reconciler/consumer/consumer.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

control-plane/pkg/reconciler/consumer/consumer.go#L318

Added line #L318 was not covered by tests

Check warning on line 321 in control-plane/pkg/reconciler/consumer/consumer.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

control-plane/pkg/reconciler/consumer/consumer.go#L321

Added line #L321 was not covered by tests

Check warning on line 334 in control-plane/pkg/reconciler/consumer/consumer.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

control-plane/pkg/reconciler/consumer/consumer.go#L329-L334

Added lines #L329 - L334 were not covered by tests

Check warning on line 336 in control-plane/pkg/reconciler/consumer/consumer.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

control-plane/pkg/reconciler/consumer/consumer.go#L336

Added line #L336 was not covered by tests