Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.14] Fix EOF errors when using SASL_SSL PLAIN #4125

Merged
merged 1 commit into from
Oct 7, 2024
Merged

[release-1.14] Fix EOF errors when using SASL_SSL PLAIN #4125

merged 1 commit into from
Oct 7, 2024

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Oct 7, 2024

The consumergroup reconciler was using the legacy secret format resolver to configure the Sarama client even in the Kafka Broker case.

We can't really add a E2E regression test as strimzi doesn't support SASL/PLAIN: see strimzi/strimzi-kafka-operator/issues/2221

Fixes #4091

Proposed Changes

Release Note

Fix `EOF` errors when using `SASL_SSL` `PLAIN` to connect to Apache Kafka cluster.

Docs

@pierDipi
Fix EOF errors when using SASL_SSL PLAIN
019fb27 
The consumergroup reconciler was using the legacy secret format resolver
to configure the Sarama client even in the Kafka Broker case.

We can't really add a E2E regression test as strimzi doesn't support
`SASL/PLAIN`: see `strimzi/strimzi-kafka-operator/issues/2221`

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/control-plane labels Oct 7, 2024
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@pierDipi pierDipi changed the title [WIP] Fix EOF errors when using SASL_SSL PLAIN [WIP] [release-1.14] Fix EOF errors when using SASL_SSL PLAIN Oct 7, 2024
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 7, 2024
@pierDipi
Copy link
Member Author

pierDipi commented Oct 7, 2024

/retest

@pierDipi
Copy link
Member Author

pierDipi commented Oct 7, 2024

/cherry-pick release-1.15

@knative-prow-robot
Copy link
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi pierDipi changed the title [WIP] [release-1.14] Fix EOF errors when using SASL_SSL PLAIN [release-1.14] Fix EOF errors when using SASL_SSL PLAIN Oct 7, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2024
matzew
matzew approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f436cd9 into knative-extensions:release-1.14 Oct 7, 2024
34 checks passed
@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #4127

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Oct 7, 2024
Closed
@pierDipi pierDipi deleted the fix-consumergoup-eof-sasl_ssl-plain branch October 7, 2024 14:59
@mdwhitley mdwhitley mentioned this pull request Oct 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@odacremolbap odacremolbap Awaiting requested review from odacremolbap

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierDipi @knative-prow-robot @matzew