We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug The instructions in the README do not work since 1.13 : https://github.com/knative-extensions/eventing-redis/tree/main/config/source
And the modifications in code does not allow to start the redis source stream without a TLS certificate for Redis.
An error log in redis stream source pod:
panic: panic called with nil argument goroutine 1 [running]: [knative.dev/eventing-redis/pkg/source/adapter.(*Adapter).newPool.func1()](http://knative.dev/eventing-redis/pkg/source/adapter.(*Adapter).newPool.func1()) [knative.dev/eventing-redis/pkg/source/adapter/adapter.go:244](http://knative.dev/eventing-redis/pkg/source/adapter/adapter.go:244) +0x3ab
Expected behavior Without TLS certificate for Redis in the secret it should run properly
To Reproduce Follow the README here: https://github.com/knative-extensions/eventing-redis/tree/main/config/source
Knative release version 1.15.0
Additional context The tls-secret.yaml file contains a default certificate: https://github.com/knative-extensions/eventing-redis/blob/main/config/source/tls-secret.yaml If we replace the tls_cert value by "" like:
""
stringData: # the data is abbreviated in this example TLS_CERT: ""
it fails in pkg/source/reconciler/streamsource/streamsource.go:136
pkg/source/reconciler/streamsource/streamsource.go:136
The text was updated successfully, but these errors were encountered:
Fix knative-extensions#626 Do no affect Redis Config nor TLS Config i…
8f2077b
…f they are nil
f25bbc9
Successfully merging a pull request may close this issue.
Describe the bug
The instructions in the README do not work since 1.13 : https://github.com/knative-extensions/eventing-redis/tree/main/config/source
And the modifications in code does not allow to start the redis source stream without a TLS certificate for Redis.
An error log in redis stream source pod:
Expected behavior
Without TLS certificate for Redis in the secret it should run properly
To Reproduce
Follow the README here: https://github.com/knative-extensions/eventing-redis/tree/main/config/source
Knative release version
1.15.0
Additional context
The tls-secret.yaml file contains a default certificate: https://github.com/knative-extensions/eventing-redis/blob/main/config/source/tls-secret.yaml
If we replace the tls_cert value by
""
like:it fails in
pkg/source/reconciler/streamsource/streamsource.go:136
The text was updated successfully, but these errors were encountered: