Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic(nil) when the TLS certificate in Secret is the default one #626

Open
tdeverdiere opened this issue Oct 21, 2024 · 0 comments · May be fixed by #627
Open

Panic(nil) when the TLS certificate in Secret is the default one #626

tdeverdiere opened this issue Oct 21, 2024 · 0 comments · May be fixed by #627
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@tdeverdiere
Copy link
Contributor

tdeverdiere commented Oct 21, 2024

Describe the bug
The instructions in the README do not work since 1.13 : https://github.com/knative-extensions/eventing-redis/tree/main/config/source

And the modifications in code does not allow to start the redis source stream without a TLS certificate for Redis.

An error log in redis stream source pod:

panic: panic called with nil argument

goroutine 1 [running]:
[knative.dev/eventing-redis/pkg/source/adapter.(*Adapter).newPool.func1()](http://knative.dev/eventing-redis/pkg/source/adapter.(*Adapter).newPool.func1())
[knative.dev/eventing-redis/pkg/source/adapter/adapter.go:244](http://knative.dev/eventing-redis/pkg/source/adapter/adapter.go:244) +0x3ab

Expected behavior
Without TLS certificate for Redis in the secret it should run properly

To Reproduce
Follow the README here: https://github.com/knative-extensions/eventing-redis/tree/main/config/source

Knative release version
1.15.0

Additional context
The tls-secret.yaml file contains a default certificate: https://github.com/knative-extensions/eventing-redis/blob/main/config/source/tls-secret.yaml
If we replace the tls_cert value by "" like:

stringData:
  # the data is abbreviated in this example
  TLS_CERT: ""

it fails in pkg/source/reconciler/streamsource/streamsource.go:136

@tdeverdiere tdeverdiere added the kind/bug Categorizes issue or PR as related to a bug. label Oct 21, 2024
tdeverdiere added a commit to tdeverdiere/eventing-redis that referenced this issue Oct 21, 2024
@tdeverdiere tdeverdiere linked a pull request Oct 21, 2024 that will close this issue
tdeverdiere added a commit to tdeverdiere/eventing-redis that referenced this issue Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant