Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message returns #18

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

lkingland
Copy link
Contributor

  • adds optional message returns from "ready" and "alive"
  • adds documentation for development, testing, and releasing

Copy link

knative-prow bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from lance and salaboy November 6, 2024 03:41
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2024
@lkingland lkingland added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2024
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 6, 2024
@knative-prow knative-prow bot merged commit 54eeba5 into knative-extensions:main Nov 6, 2024
13 checks passed
@lkingland lkingland deleted the message-returns branch November 6, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant