Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script and GH action to verify taps #183

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Feb 29, 2024

Per title, adding a simple verification mechanism to check that taps work.

/cc @rhuss

Adding Productivity WG since it's Bash and actions, if you can take a look pls.
/cc @knative-extensions/productivity-writers

Fix #7

Copy link
Contributor

knative-prow bot commented Feb 29, 2024

@dsimansk: GitHub didn't allow me to request PR reviews from the following users: knative-extensions/productivity-writers.

Note that only knative-extensions members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Per title, adding a simple verification mechanism to check that taps work.

/cc @rhuss

Adding Productivity WG since it's Bash and actions, if you can take a look pls.
/cc @knative-extensions/productivity-writers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 29, 2024
@dsimansk
Copy link
Contributor Author

I'll create very similar one for the main tap as well.

@@ -1,6 +1,6 @@
require 'fileutils'

class Func < Formula
class FuncAT025 < Formula
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required change to have test passing. Otherwise it's very nicely reporting failure. :)

@rhuss
Copy link
Contributor

rhuss commented Feb 29, 2024

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@dsimansk
Copy link
Contributor Author

dsimansk commented Feb 29, 2024

@rhuss fixed one more wrong checksum in func@1.7.rb. All should be green now 🤞.

@rhuss
Copy link
Contributor

rhuss commented Feb 29, 2024

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
Copy link
Contributor

knative-prow bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 3b96814 into knative-extensions:main Feb 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e tests
2 participants