Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.14] Set CORS policy values only for when HTTPProxy associated with external visibility #1089

Conversation

knative-prow-robot
Copy link
Contributor

@knative-prow-robot knative-prow-robot commented May 14, 2024

This is an automated cherry-pick of #1088

Apply CORS policy on external routes

@knative-prow knative-prow bot requested review from izabelacg and skonto May 14, 2024 14:32
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 14, 2024
@dprotaso
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
Copy link

knative-prow bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-1.14@fc93044). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.14    #1089   +/-   ##
===============================================
  Coverage                ?   93.92%           
===============================================
  Files                   ?       11           
  Lines                   ?      708           
  Branches                ?        0           
===============================================
  Hits                    ?      665           
  Misses                  ?       22           
  Partials                ?       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit f3bb986 into knative-extensions:release-1.14 May 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants