Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Feb 19, 2024

drop toolchain directive -dprotaso

/cc knative-extensions/serving-writers
/assign knative-extensions/serving-writers

Produced by: knative-extensions/knobots/actions/update-deps

@knative-prow knative-prow bot requested a review from a team February 19, 2024 02:06
Copy link

knative-prow bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation
Once this PR has been reviewed and has the lgtm label, please assign pierdipi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dfdcd00) 91.47% compared to head (3a2d4e6) 91.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #593   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files           5        5           
  Lines         305      305           
=======================================
  Hits          279      279           
  Misses         14       14           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 19, 2024
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch 2 times, most recently from 4679a58 to a8ea03a Compare February 21, 2024 01:56
Signed-off-by: Knative Automation <automation@knative.team>
Copy link

knative-prow bot commented Feb 21, 2024

@knative-automation: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-tests_net-http01_main 3a2d4e6 link true /test integration-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dprotaso dprotaso closed this Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants