Use ko label filter instead of removing KnativeCertificate yaml (#1224)

knative-extensions · Dec 7, 2023 · 6899886 · 6899886
1 parent e6e6cb7
commit 6899886
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/config/700-istio-knative-certificate.yaml b/config/700-istio-knative-certificate.yaml
@@ -19,6 +19,7 @@ metadata:
     networking.knative.dev/certificate.class: cert-manager.certificate.networking.knative.dev
   labels:
     networking.knative.dev/certificate-type: system-internal
+    knative.dev/install-knative-certificate: "true"
   name: routing-serving-certs
   namespace: istio-system
 spec:

diff --git a/test/e2e-common.sh b/test/e2e-common.sh
@@ -69,11 +69,9 @@ function test_setup() {
 
   ${istio_dir}/install-istio.sh ${istio_profile} || return 1
 
-  # Remove Knative Certificate as we are running without Serving CRs
-  rm -f config/700-istio-knative-certificate.yaml
-
   echo ">> Bringing up net-istio Ingress Controller"
-  ko apply --platform=linux/amd64 -f config/ || return 1
+  # Do not install Knative Certificate for e2e tests, as we are running without Serving CRs
+  ko apply --platform=linux/amd64 -l knative.dev/install-knative-certificate!=true -f config/ || return 1
 
   if [[ -f "${istio_dir}/${istio_profile}/config-istio.yaml" ]]; then
     kubectl apply -f "${istio_dir}/${istio_profile}/config-istio.yaml"