Skip to content

Commit

Permalink
Delete KnativeCertificate in e2e tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ReToCode committed Nov 30, 2023
1 parent e5e9ab7 commit e042991
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/kind-e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ jobs:
# Deploy Istio
./third_party/istio-${{ matrix.istio-version }}/install-istio.sh istio-kind-${{ matrix.istio-profile }}
# Remove Knative Certificate as we are running without Serving CRs
rm -f config/700-istio-knative-certificate.yaml
# Build and Publish our containers to the docker daemon (including test assets)
ko resolve --platform=linux/amd64 -f test/config/ -f config/ | kubectl apply -f -

Expand Down
3 changes: 3 additions & 0 deletions test/e2e-common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ function test_setup() {

${istio_dir}/install-istio.sh ${istio_profile} || return 1

# Remove Knative Certificate as we are running without Serving CRs
rm -f config/700-istio-knative-certificate.yaml

echo ">> Bringing up net-istio Ingress Controller"
ko apply --platform=linux/amd64 -f config/ || return 1

Expand Down

0 comments on commit e042991

Please sign in to comment.