Skip to content

Commit

Permalink
Minor fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
ReToCode committed Oct 9, 2023
1 parent a5c4941 commit e497120
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ istioctl install -y
Run the following command to install Knative

```shell
kubectl apply --filename https://storage.googleapis.com/knative-nightly/serving/latest/serving-crds.yaml
kubectl apply --filename https://storage.googleapis.com/knative-nightly/serving/latest/serving-core.yaml
kubectl apply -f https://github.com/knative/serving/releases/latest/download/serving-crds.yaml
kubectl apply -f https://github.com/knative/serving/releases/latest/download/serving-core.yaml
```

### Install Knative net-istio
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/ingress/ingress.go
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ func (r *Reconciler) reconcileVirtualServices(ctx context.Context, ing *v1alpha1
}

func (r *Reconciler) reconcileDestinationRules(ctx context.Context, ing *v1alpha1.Ingress) error {
var drs = sets.String{}
var drs = sets.New[string]()
for _, rule := range ing.Spec.Rules {
for _, path := range rule.HTTP.Paths {
// Currently DomainMappings point to the cluster local domain on the local gateway.
Expand Down
8 changes: 4 additions & 4 deletions pkg/reconciler/ingress/ingress_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,7 @@ func TestReconcile_EnableSystemInternalTLS(t *testing.T) {
}))
}

func TestReconcile_EnableAutoTLS(t *testing.T) {
func TestReconcile_ExternalDomainTLS(t *testing.T) {
table := TableTest{{
Name: "create Ingress Gateway to match newly created Ingress",
SkipNamespaceValidation: true,
Expand Down Expand Up @@ -1252,8 +1252,8 @@ func TestReconcile_EnableAutoTLS(t *testing.T) {
}},
},
Network: &netconfig.Config{
HTTPProtocol: netconfig.HTTPDisabled,
AutoTLS: true,
HTTPProtocol: netconfig.HTTPDisabled,
ExternalDomainTLS: true,
},
},
},
Expand Down Expand Up @@ -1406,7 +1406,7 @@ func ReconcilerTestConfig() *config.Config {
}},
},
Network: &netconfig.Config{
AutoTLS: false,
ExternalDomainTLS: false,
},
}
}
Expand Down

0 comments on commit e497120

Please sign in to comment.